* [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
@ 2016-11-24 7:14 Changming Huang
2016-11-30 2:39 ` Jerry Huang
0 siblings, 1 reply; 5+ messages in thread
From: Changming Huang @ 2016-11-24 7:14 UTC (permalink / raw)
To: u-boot
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang <jerry.huang@nxp.com>
---
drivers/usb/common/fsl-errata.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c
index 0dc3dd8..59a69a1 100644
--- a/drivers/usb/common/fsl-errata.c
+++ b/drivers/usb/common/fsl-errata.c
@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
case SVR_9132:
return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);
#endif
+#ifdef CONFIG_ARM
+ case SVR_LS1012A:
+ return IS_SVR_REV(svr, 1, 0);
+#endif
}
return false;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
2016-11-24 7:14 [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a Changming Huang
@ 2016-11-30 2:39 ` Jerry Huang
2016-11-30 5:09 ` york sun
2016-11-30 19:09 ` york sun
0 siblings, 2 replies; 5+ messages in thread
From: Jerry Huang @ 2016-11-30 2:39 UTC (permalink / raw)
To: u-boot
Any comment for this patch?
Best Regards
Jerry Huang
-----Original Message-----
From: Changming Huang [mailto:jerry.huang at nxp.com]
Sent: Thursday, November 24, 2016 3:14 PM
To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de
Cc: Jerry Huang <jerry.huang@nxp.com>
Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by: Changming Huang <jerry.huang@nxp.com>
---
drivers/usb/common/fsl-errata.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644
--- a/drivers/usb/common/fsl-errata.c
+++ b/drivers/usb/common/fsl-errata.c
@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
case SVR_9132:
return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif
+#ifdef CONFIG_ARM
+ case SVR_LS1012A:
+ return IS_SVR_REV(svr, 1, 0);
+#endif
}
return false;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
2016-11-30 2:39 ` Jerry Huang
@ 2016-11-30 5:09 ` york sun
2016-11-30 19:09 ` york sun
1 sibling, 0 replies; 5+ messages in thread
From: york sun @ 2016-11-30 5:09 UTC (permalink / raw)
To: u-boot
On 11/29/2016 06:39 PM, Jerry Huang wrote:
> Any comment for this patch?
>
Looks simple enough.
York
> Best Regards
> Jerry Huang
>
> -----Original Message-----
> From: Changming Huang [mailto:jerry.huang at nxp.com]
> Sent: Thursday, November 24, 2016 3:14 PM
> To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Jerry Huang <jerry.huang@nxp.com>
> Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
>
> Enable the errata-a005697 for ls1012a
>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
> drivers/usb/common/fsl-errata.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644
> --- a/drivers/usb/common/fsl-errata.c
> +++ b/drivers/usb/common/fsl-errata.c
> @@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
> case SVR_9132:
> return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif
> +#ifdef CONFIG_ARM
> + case SVR_LS1012A:
> + return IS_SVR_REV(svr, 1, 0);
> +#endif
> }
> return false;
> }
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
2016-11-30 2:39 ` Jerry Huang
2016-11-30 5:09 ` york sun
@ 2016-11-30 19:09 ` york sun
2016-12-01 3:27 ` Jerry Huang
1 sibling, 1 reply; 5+ messages in thread
From: york sun @ 2016-11-30 19:09 UTC (permalink / raw)
To: u-boot
On 11/29/2016 06:39 PM, Jerry Huang wrote:
> Any comment for this patch?
>
> Best Regards
> Jerry Huang
>
> -----Original Message-----
> From: Changming Huang [mailto:jerry.huang at nxp.com]
> Sent: Thursday, November 24, 2016 3:14 PM
> To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Jerry Huang <jerry.huang@nxp.com>
> Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
>
> Enable the errata-a005697 for ls1012a
>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
> drivers/usb/common/fsl-errata.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644
> --- a/drivers/usb/common/fsl-errata.c
> +++ b/drivers/usb/common/fsl-errata.c
> @@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
> case SVR_9132:
> return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif
> +#ifdef CONFIG_ARM
> + case SVR_LS1012A:
> + return IS_SVR_REV(svr, 1, 0);
> +#endif
> }
Actually this patch has a problem with the SVR. SVR_LS1012A is defined
in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see
compiling errors for LS1021A, eg ls1021atwr_nor.
York
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
2016-11-30 19:09 ` york sun
@ 2016-12-01 3:27 ` Jerry Huang
0 siblings, 0 replies; 5+ messages in thread
From: Jerry Huang @ 2016-12-01 3:27 UTC (permalink / raw)
To: u-boot
York,
I don't know the file " arch/arm/include/asm/arch-fsl-layerscape/soc.h " is not included for ls1021a, maybe ls1021a is one special ARM SoC.
Now I will add one macro " CONFIG_LS1012A " to resolve this issue.
Best Regards
Jerry Huang
-----Original Message-----
From: york sun
Sent: Thursday, December 01, 2016 3:10 AM
To: Jerry Huang <jerry.huang@nxp.com>; u-boot at lists.denx.de
Subject: Re: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
On 11/29/2016 06:39 PM, Jerry Huang wrote:
> Any comment for this patch?
>
> Best Regards
> Jerry Huang
>
> -----Original Message-----
> From: Changming Huang [mailto:jerry.huang at nxp.com]
> Sent: Thursday, November 24, 2016 3:14 PM
> To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Jerry Huang <jerry.huang@nxp.com>
> Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
>
> Enable the errata-a005697 for ls1012a
>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
> drivers/usb/common/fsl-errata.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/common/fsl-errata.c
> b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644
> --- a/drivers/usb/common/fsl-errata.c
> +++ b/drivers/usb/common/fsl-errata.c
> @@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
> case SVR_9132:
> return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1); #endif
> +#ifdef CONFIG_ARM
> + case SVR_LS1012A:
> + return IS_SVR_REV(svr, 1, 0);
> +#endif
> }
Actually this patch has a problem with the SVR. SVR_LS1012A is defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see compiling errors for LS1021A, eg ls1021atwr_nor.
York
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-01 3:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 7:14 [U-Boot] [PATCH] fsl/usb: enable the errata-a005697 for ls1012a Changming Huang
2016-11-30 2:39 ` Jerry Huang
2016-11-30 5:09 ` york sun
2016-11-30 19:09 ` york sun
2016-12-01 3:27 ` Jerry Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox