[U-Boot] [PATCH 4/6] arm64: mvebu: Add pin control nodes to A8K family DTS files

Stefan Roese
2016-11-24T16:00:37Z

Hi Kosta,

On 24.11.2016 15:09, Kostya Porotchkin wrote:
> Thank you for your review!
> I will put all required changes into second patch version.

Thanks.

> Regarding the symbolic names for the pin controller functions
> and lack of documentation.
> The problem is that same function number does not have the
> same meaning for different pins.
> So if I want to put symbolic names instead of numbers, I have
> to add large structures defining symbolic names for each
> function on every pin as a platform data.
> I think in this case I will loose the driver code compactness
> provided by the FDT usage.

I suspected that something like this might be the reason for
the "plain numbers". But I also suspect that other SoCs might
suffer from the same problem. Did you take a look at other
pinctrl implementation (not only in U-Boot but also in Linux).
How is this solved for other SoCs (if this problem exists there
as well)?

> I can create a documentation file with all pin function values
> taken from SoC HW manual and keep the numeric function IDs for
> the DTS usage.

Is this something that you will create manually? Or can this
be created automatically from some documentation of internal
source? I'm asking, since manual creation always has the
potential problem of erroneous values.

> Will it be good enough?

This will help of course.

Thanks,
Stefan