From mboxrd@z Thu Jan 1 00:00:00 1970 From: Champ, Andy Date: Mon, 28 Nov 2016 09:59:33 +0000 Subject: [U-Boot] Macronix NOR_SPI and Quad I/O In-Reply-To: References: <1480091837674.61259@amazon.co.uk>, Message-ID: <1480327172425.94107@amazon.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de I don't have anything that does Quad IO, so I can't test it either. I think the best thing to do is to disable it for the Macronix parts, and put a comment in the table explaining why. With any luck one day somebody somewhere will have a device with a Macronix chip and quad I/O, and they can do it properly. If this sounds good I'll put a patch together, run it past our open source lawyers (I'm not allowed to just push!) and send it through. Alternatively I could put together a patch that sets a different flag bit for Macronix Quad I/O and push that. The only thing is of course that I have no way to test it, and as we all know untested code never works. Which way should I go? Regards Andy Champ ________________________________________ From: Jagan Teki Sent: 26 November 2016 03:13 To: Champ, Andy Cc: u-boot at lists.denx.de; jteki at openedev.com; radu.bacrau at gmail.com; clsee at altera.com; dumitru.bacrau at intel.com Subject: Re: [U-Boot] Macronix NOR_SPI and Quad I/O On Fri, Nov 25, 2016 at 10:07 PM, Champ, Andy wrote: > Hi all, > > > in the table in drivers/mtd/spi/spi_flash_ids.c there is a flag WR_QPP set against Macronix devices (including the ones Dumitru is just adding). > > > This is used when programming the devices on a 4-bit bus to select the command to use for programming - either CMD_QUAD_PAGE_PROGRAM (0x32) or CMD_PAGE_PROGRAM (0x2). > > > The Macronix devices that I have a spec for do not mention command 0x32. Each of the devices that I have a spec for ( MX25L25635F MX25U51245G MX25V8035F and MX25V1635F ) use command 0x38 instead. We need to fix this, till now no Macronix has been tested with QUAD I think, please send the suitable fix will review. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.