[U-Boot] [PATCH v3 13/13] imx6: icorem6: Add I2C support

Heiko Schocher
2016-12-06T14:10:33Z

Hello Jagan,

Am 06.12.2016 um 00:01 schrieb Jagan Teki:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Add I2C support for Engicam i.CoreM6 qdl board.
>
> icorem6qdl> i2c bus
> Bus 0: i2c at 021a0000
> Bus 1: i2c at 021a4000
> Bus 2: i2c at 021a8000
> icorem6qdl> i2c dev 2
> Setting bus to 2
> icorem6qdl> i2c speed 100000
> Setting bus speed to 100000 Hz
> icorem6qdl> i2c probe
> Valid chip addresses: 2C
> icorem6qdl> i2c md 2C 0xff
> 00ff: 00 00 00 00 0f f0 01 64 ff ff 00 00 00 00 00 00 .......d........
>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> arch/arm/cpu/armv7/mx6/Kconfig | 1 +
> configs/imx6qdl_icore_mmc_defconfig | 3 ++-
> configs/imx6qdl_icore_nand_defconfig | 3 ++-
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/Kconfig b/arch/arm/cpu/armv7/mx6/Kconfig
> index f1ec75d..b686476 100644
> --- a/arch/arm/cpu/armv7/mx6/Kconfig
> +++ b/arch/arm/cpu/armv7/mx6/Kconfig
> @@ -110,6 +110,7 @@ config TARGET_MX6Q_ICORE
> select DM
> select DM_ETH
> select DM_GPIO
> + select DM_I2C
> select DM_MMC
> select DM_THERMAL
> select SUPPORT_SPL
> diff --git a/configs/imx6qdl_icore_mmc_defconfig b/configs/imx6qdl_icore_mmc_defconfig
> index 6fa85de..5f09425 100644
> --- a/configs/imx6qdl_icore_mmc_defconfig
> +++ b/configs/imx6qdl_icore_mmc_defconfig
> @@ -17,6 +17,7 @@ CONFIG_SYS_MAXARGS=32
> # CONFIG_DM_MMC_OPS is not set
> CONFIG_CMD_BOOTZ=y
> CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
> CONFIG_CMD_MII=y
> CONFIG_CMD_PING=y
> CONFIG_CMD_MEMTEST=y
> @@ -33,6 +34,7 @@ CONFIG_MXC_UART=y
> CONFIG_IMX_THERMAL=y
> CONFIG_PINCTRL=y
> CONFIG_PINCTRL_IMX6=y
> +CONFIG_SYS_I2C_MXC=y
> CONFIG_VIDEO=y
> CONFIG_VIDEO_IPUV3=y
> CONFIG_SYS_CONSOLE_IS_IN_ENV=y
> @@ -40,7 +42,6 @@ CONFIG_SPL_LIBDISK_SUPPORT=y
> CONFIG_SPL_LIBCOMMON_SUPPORT=y
> CONFIG_SPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_SERIAL_SUPPORT=y
> -CONFIG_SPL_I2C_SUPPORT=y

You remove here SPL I2C support ... is this intented ?

If so, you can add my:

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
> CONFIG_SPL_GPIO_SUPPORT=y
> CONFIG_SPL_WATCHDOG_SUPPORT=y
> CONFIG_SPL_EXT_SUPPORT=y
> diff --git a/configs/imx6qdl_icore_nand_defconfig b/configs/imx6qdl_icore_nand_defconfig
> index b32eea9..af3a9f8 100644
> --- a/configs/imx6qdl_icore_nand_defconfig
> +++ b/configs/imx6qdl_icore_nand_defconfig
> @@ -15,6 +15,7 @@ CONFIG_SYS_MAXARGS=32
> # CONFIG_CMD_IMLS is not set
> CONFIG_CMD_BOOTZ=y
> CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
> CONFIG_CMD_MII=y
> CONFIG_CMD_PING=y
> CONFIG_CMD_MEMTEST=y
> @@ -29,13 +30,13 @@ CONFIG_IMX_THERMAL=y
> # CONFIG_DM_MMC_OPS is not set
> CONFIG_PINCTRL=y
> CONFIG_PINCTRL_IMX6=y
> +CONFIG_SYS_I2C_MXC=y
> CONFIG_VIDEO=y
> CONFIG_VIDEO_IPUV3=y
> CONFIG_SYS_CONSOLE_IS_IN_ENV=y
> CONFIG_SPL_LIBCOMMON_SUPPORT=y
> CONFIG_SPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_SERIAL_SUPPORT=y
> -CONFIG_SPL_I2C_SUPPORT=y
> CONFIG_SPL_GPIO_SUPPORT=y
> CONFIG_SPL_WATCHDOG_SUPPORT=y
> CONFIG_SPL_DMA_SUPPORT=y
>

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany