From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vlad Zakharov <Vladislav.Zakharov@synopsys.com>
Date: Mon, 19 Dec 2016 13:53:57 +0000
Subject: [U-Boot] [PATCH v3] timer: Support clocks via phandle
In-Reply-To: <1481293112-18577-1-git-send-email-vzakhar@synopsys.com>
References: <1481293112-18577-1-git-send-email-vzakhar@synopsys.com>
Message-ID: <1482155637.3601.2.camel@synopsys.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On Fri, 2016-12-09 at 17:18 +0300, Vlad Zakharov wrote:
> Earlier timer driver needed a clock-frequency property in compatible
> device-tree nodes. Another way is to reference a clock via a phandle.
> 
> So now timer_pre_probe tries to get clock by reference through device
> tree. In case it is impossible to get clock device through the
> reference, clock-frequency property of the timer node is read to provide
> backward compatibility.
> 
> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> Changes v2..v3:
> ?- Use value type instead of pointer for timer_clk in order to fix
> build time warnings
> 
> ?drivers/timer/timer-uclass.c | 17 ++++++++++++++---
> ?1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/timer/timer-uclass.c b/drivers/timer/timer-uclass.c
> index f8ddf93..5c63e6b 100644
> --- a/drivers/timer/timer-uclass.c
> +++ b/drivers/timer/timer-uclass.c
> @@ -8,6 +8,7 @@
> ?#include <dm.h>
> ?#include <dm/lists.h>
> ?#include <dm/device-internal.h>
> +#include <clk.h>
> ?#include <errno.h>
> ?#include <timer.h>
> ?
> @@ -42,9 +43,19 @@ unsigned long notrace timer_get_rate(struct udevice *dev)
> ?static int timer_pre_probe(struct udevice *dev)
> ?{
> ?	struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev);
> -
> -	uc_priv->clock_rate = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
> -					?????"clock-frequency", 0);
> +	struct clk timer_clk;
> +	int err;
> +	ulong ret;
> +
> +	err = clk_get_by_index(dev, 0, &timer_clk);
> +	if (!err) {
> +		ret = clk_get_rate(&timer_clk);
> +		if (IS_ERR_VALUE(ret))
> +			return ret;
> +		uc_priv->clock_rate = ret;
> +	} else
> +		uc_priv->clock_rate = fdtdec_get_int(gd->fdt_blob,
> +				dev->of_offset,	"clock-frequency", 0);
> ?
> ?	return 0;
> ?}

Could you please apply this patch if there's no any objections or comments on it?
Thanks.

-- 
Best regards,
Vlad Zakharov <vzakhar@synopsys.com>