From mboxrd@z Thu Jan 1 00:00:00 1970 From: Westergreen, Dalon Date: Sun, 22 Jan 2017 06:29:54 +0000 Subject: [U-Boot] [PATCH 3/7] arm: socfpga: update arria5 socdk default environment In-Reply-To: <9c76207a-5d8f-c908-0d29-4b61e7a29a59@denx.de> References: <1485019919-1926-1-git-send-email-dwesterg@gmail.com> <1485019919-1926-3-git-send-email-dwesterg@gmail.com> <3d717678-1f1e-ced2-6a67-2375176d5cf0@denx.de> <1485039897.20684.25.camel@intel.com> <9c76207a-5d8f-c908-0d29-4b61e7a29a59@denx.de> Message-ID: <1485066592.20684.36.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2017-01-22 at 01:36 +0100, Marek Vasut wrote: > On 01/22/2017 12:04 AM, Westergreen, Dalon wrote: > > > > On Sat, 2017-01-21 at 20:29 +0100, Marek Vasut wrote: > > > > > > On 01/21/2017 06:31 PM, Dalon Westergreen wrote: > > > > > > > > > > > > From: Dalon Westergreen > > > > > > > > The default values for CONFIG_SYS_MMCSD_FS_BOOT_PARTITION > > > > and CONFIG_SYS_MMCSD_FS_OS_PARTITION have changed and as > > > > as result the default uboot environment for this board > > > > needs updating.??This sets the default envirnment to > > > > use the CONFIG_SYS_MMCSD_FS_BOOT_PARTITION and > > > > CONFIG_SYS_MMCSD_FS_OS_PARTITION configs for the boot > > > > and os partitions. > > > > > > > > Also set the default fdtimage value to match the > > > > devicetree name in the linux kernel for this board. > > > > > > > > Signed-off-by: Dalon Westergreen > > > > > > Acked-by: Marek Vasut > > > > > > but please see my comment on 1/7 > > > > > > btw I think this is repeating too much, why don't we pull the env into > > > socfpga_common.h first ? > > > > I'd prefer to keep the boards separate and look at > > moving to disto boot. > > If you create common env in socfpga_common.h first and then update it, > the update will be in a single patch changing a single file. So will > then be the switch to distro bootcmd. I would prefer such course of > action over many patches doing the same thing in many files. > > Given how similar (and broken) the envs are for those boards, pulling > the common env should be easy and very beneficial. > Okay, agreed. ?I will move all of the common env variables to? socfpga_common.h. ?I will change the new board patch to do the same. -- Thanks, Dalon