public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dalon Westergreen <dwesterg@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] SPL: Move SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig
Date: Fri, 03 Feb 2017 11:15:21 -0800	[thread overview]
Message-ID: <1486149321.19265.63.camel@gmail.com> (raw)
In-Reply-To: <20170203171736.GG20208@bill-the-cat>

On Fri, 2017-02-03 at 12:17 -0500, Tom Rini wrote:
> On Fri, Feb 03, 2017 at 09:13:43AM -0800, Dalon Westergreen wrote:
> > 
> > On Fri, 2017-02-03 at 11:05 -0600, Dinh Nguyen wrote:
> > > 
> > > Hi Dalon,
> > > 
> > > On 02/01/2017 10:45 AM, Dalon Westergreen wrote:
> > > > 
> > > > 
> > > > From: Dalon Westergreen <dalon.westergreen@intel.com>
> > > > 
> > > > Added SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and
> > > > SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig.
> > > > 
> > > > set to default y for socfpga platforms, and add appropriate
> > > > configurations for kc1, snipper, and db-88f6820-gp boards.
> > > > 
> > > > Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> > > > ---
> > > > ?common/spl/Kconfig??????????????| 18 +++++++++++++++++-
> > > > ?common/spl/spl_mmc.c????????????| 12 +++---------
> > > > ?configs/db-88f6820-gp_defconfig |??1 +
> > > > ?configs/kc1_defconfig???????????|??2 ++
> > > > ?configs/sniper_defconfig????????|??2 ++
> > > > ?include/configs/db-88f6820-gp.h |??1 -
> > > > ?include/configs/kc1.h???????????|??2 --
> > > > ?include/configs/sniper.h????????|??2 --
> > > > ?8 files changed, 25 insertions(+), 15 deletions(-)
> > > > 
> > > 
> > > I'm get this warning:
> > > 
> > > include/configs/socfpga_common.h:316:0: warning:
> > > "CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION" redefined
> > > ?#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION 1
> > > 
> > > Need to remove the CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION from
> > > socfpga_common.h as well.
> > Yes, i am aware, but have a separate patch set already for the socfpga
> > headers. ?i think it may be best just to redo those after this is
> > merged. ?i will add the modifications to the socfpga headers.
> 
> The series needs to be complete and not add warnings.??Ideally we won't
> add warnings in one patch and fix them in a later patch.
> 
okay. ?this is fixed in the v5 patches i just sent.

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2017-02-03 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 16:45 [U-Boot] [PATCH v4 1/2] SPL: add support to boot from a partition type Dalon Westergreen
2017-02-01 16:45 ` [U-Boot] [PATCH v4 2/2] SPL: Move SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig Dalon Westergreen
2017-02-03 17:05   ` Dinh Nguyen
2017-02-03 17:13     ` Dalon Westergreen
2017-02-03 17:17       ` Tom Rini
2017-02-03 19:15         ` Dalon Westergreen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-03 18:36 [U-Boot] [PATCH v4 0/2] SPL: Add support to boot a partition type Dalon Westergreen
2017-02-03 18:36 ` [U-Boot] [PATCH v4 2/2] SPL: Move SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig Dalon Westergreen
2017-02-09 10:06   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486149321.19265.63.camel@gmail.com \
    --to=dwesterg@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox