From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/3] x86: Intel MID platforms has no microcode update
Date: Wed, 15 Feb 2017 11:52:41 +0200 [thread overview]
Message-ID: <1487152361.2133.480.camel@linux.intel.com> (raw)
In-Reply-To: <CAEUhbmV2GEtZvyrqb5FkshC4DsfZ+3c3OkYtXOo_SdVLu8wxDA@mail.gmail.com>
On Wed, 2017-02-15 at 11:10 +0800, Bin Meng wrote:
> Hi Andy,
>
> On Tue, Feb 14, 2017 at 10:47 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > There is no microcode update available for SoCs used on Intel MID
> > platforms.
> >
> > Use conditional to bypass it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > ?arch/x86/cpu/mp_init.c | 2 +-
> > ?1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/cpu/mp_init.c b/arch/x86/cpu/mp_init.c
> > index 988073cc79..4e2f000f75 100644
> > --- a/arch/x86/cpu/mp_init.c
> > +++ b/arch/x86/cpu/mp_init.c
> > @@ -248,7 +248,7 @@ static int load_sipi_vector(atomic_t
> > **ap_countp, int num_cpus)
> > ????????if (!stack)
> > ????????????????return -ENOMEM;
> > ????????params->stack_top = (u32)(stack + size);
> > -#if !defined(CONFIG_QEMU) && !defined(CONFIG_HAVE_FSP)
> > +#if !defined(CONFIG_QEMU) && !defined(CONFIG_HAVE_FSP) &&
> > !defined(CONFIG_INTEL_MID)
> > ????????params->microcode_ptr = ucode_base;
> > ????????debug("Microcode at %x\n", params->microcode_ptr);
> > ?#endif
>
> Is this patch necessary? If Intel MID does not define CONFIG_QEMU or
> CONFIG_HAVE_FSP, current logic should work.
This code is executed when neither of option is defined. For Intel MID
we do *not* need to have this code executed.
I dunno how it possible can work otherwise (ucode_base is not defined).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-02-15 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 14:47 [U-Boot] [PATCH v1 1/3] x86: Introduce INTEL_MID quirk option Andy Shevchenko
2017-02-14 14:47 ` [U-Boot] [PATCH v1 2/3] x86: zImage: add Intel MID platforms support Andy Shevchenko
2017-02-15 3:08 ` Bin Meng
2017-02-16 20:44 ` Simon Glass
2017-02-14 14:47 ` [U-Boot] [PATCH v1 3/3] x86: Intel MID platforms has no microcode update Andy Shevchenko
2017-02-15 3:10 ` Bin Meng
2017-02-15 9:52 ` Andy Shevchenko [this message]
2017-02-17 1:22 ` Bin Meng
2017-02-17 13:44 ` Andy Shevchenko
2017-02-16 20:44 ` Simon Glass
2017-02-15 3:00 ` [U-Boot] [PATCH v1 1/3] x86: Introduce INTEL_MID quirk option Bin Meng
2017-02-15 9:50 ` Andy Shevchenko
2017-02-15 10:09 ` Bin Meng
2017-02-15 10:15 ` Andy Shevchenko
2017-02-17 1:19 ` Bin Meng
2017-02-16 20:44 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487152361.2133.480.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox