From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dalon Westergreen Date: Sun, 19 Feb 2017 11:59:51 -0800 Subject: [U-Boot] [PATCH 1/8] arm: socfpga: Add distro boot to socfpga common header In-Reply-To: <20170219194555.GA16718@amd> References: <1487451108-4277-1-git-send-email-dwesterg@gmail.com> <1487451108-4277-2-git-send-email-dwesterg@gmail.com> <60b20eb9-0625-b2eb-712c-df75cb993c66@denx.de> <1487460588.6396.18.camel@gmail.com> <1487466604.6396.29.camel@gmail.com> <20170219194555.GA16718@amd> Message-ID: <1487534391.13957.3.camel@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2017-02-19 at 20:45 +0100, Pavel Machek wrote: > Hi! > > > > > > > > > > > > > > > > > > > > > > > > > > > ?/* Environment for SDMMC boot */ > > > > > > ?#if defined(CONFIG_ENV_IS_IN_MMC) && !defined(CONFIG_ENV_OFFSET) > > > > > > -#define CONFIG_SYS_MMC_ENV_DEV 0 /* device 0 > > > > > > */ > > > > > > -#define CONFIG_ENV_OFFSET 512 /* just after > > > > > > the > > > > > > MBR > > > > > > */ > > > > > > +#define CONFIG_SYS_MMC_ENV_DEV 0 /* > > > > > > device 0 > > > > > > */ > > > > > > +#define CONFIG_ENV_OFFSET (34*512)/* just after the > > > > > > GPT > > > > > > */ > ... > > > > I actually dont believe this will cause much of an issue. the env is placed > > immediately after the partition table. ?I know this size fits between the > > table and the typical location of the first partition without issue. > > Hmm. It is not immediately after partition table (==MBR), it is at > sector 34. Now, by changing size you already break the setups, so > moving it back to sector 1 does not help much, but can you explain? Sorry, you are right. Frank had moved it after the GPT in his patchset and i had just copied that. ?i will update this to be immediately after the mbr as it was before. --dalon > > Pavel