From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dalon Westergreen Date: Fri, 24 Feb 2017 08:48:49 -0800 Subject: [U-Boot] [PATCH v3 1/2] common: image: update boot_get_fpga to support arbitrary fpga image In-Reply-To: References: <1487602565-6349-1-git-send-email-dwesterg@gmail.com> <1487602565-6349-2-git-send-email-dwesterg@gmail.com> Message-ID: <1487954929.6827.14.camel@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2017-02-21 at 21:00 -0700, Simon Glass wrote: > Hi Dalon, > > On 20 February 2017 at 07:56, Dalon Westergreen wrote: > > > > The implementation of boot_get_fpga only supported one fpga family. > > This modification allows for any of the fpga devices supported by > > fpga_load to be used. > [snip ...] > > > > ?/* configuration node */ > > ?#define FIT_KERNEL_PROP????????????????"kernel" > > @@ -955,6 +957,9 @@ int fit_image_hash_get_value(const void *fit, int > > noffset, uint8_t **value, > > > > ?int fit_set_timestamp(void *fit, int noffset, time_t timestamp); > > > > +int fit_image_fpga_get_devnum(const void *fit, int noffset, int *devnum); > > +int fit_image_fpga_is_partial(const void *fit, int noffset); > > Can you put the function comments here instead of in the C file? Doing this would be counter to every other function in the c file these are added to, so i think it best to leave as is. --dalon > > > > + > > ?/** > > ? * fit_add_verification_data() - add verification data to FIT image nodes > > ? * > > -- > > 2.7.4 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot at lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot > > Regards, > Simon