public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] x86: Add SCU IPC driver for Intel MID platforms
Date: Mon, 20 Mar 2017 15:27:09 +0200	[thread overview]
Message-ID: <1490016429.19767.113.camel@linux.intel.com> (raw)
In-Reply-To: <CAPnjgZ272dEE_KN1PiY2oGK9Zj-6Cer0HzYmumdAThUgdD9ENA@mail.gmail.com>

On Sun, 2017-03-19 at 20:30 -0600, Simon Glass wrote:
> Hi Andy,
> 
> On 15 March 2017 at 12:42, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > From: Felipe Balbi <felipe.balbi@linux.intel.com>
> > 
> > Intel MID platforms have few microcontrollers inside SoC, one of
> > them
> > is so called System Controller Unit (SCU).
> > 
> > Here is the driver to communicate with microcontroller.
> > 
> > Signed-off-by: Vincent Tinelli <vincent.tinelli@intel.com>
> > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/Kconfig           |   2 +
> >  arch/x86/include/asm/cpu.h |   1 +
> >  arch/x86/include/asm/scu.h |  28 ++++++++
> >  arch/x86/lib/Makefile      |   1 +
> >  arch/x86/lib/scu.c         | 168
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 200 insertions(+)
> >  create mode 100644 arch/x86/include/asm/scu.h
> >  create mode 100644 arch/x86/lib/scu.c
> 
> Since this is a v2 patch can you please include a change log?

Yes.

Common:
- convert to use REGMAP instead of constant addressed IO
- rewrite as UCLASS_SYSCON modules
- move to arch/x86/lib since it's related to x86 only and there are
already another UCLASS_SYSCON modules there

SCU:
- convert function documentation to have header and body and be
consistent
- shrink header and remove unneeded attributes
- drop busy loop counter from 3m to 100k as per driver in Linux kernel

PMU:
- convert to be more generic and move Tangier related part to its own
folder (the latter out of scope of this series)

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-03-20 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 18:42 [U-Boot] [PATCH v2 1/2] x86: Add SCU IPC driver for Intel MID platforms Andy Shevchenko
2017-03-15 18:42 ` [U-Boot] [PATCH v2 2/2] x86: Introduce minimal PMU " Andy Shevchenko
2017-03-20  2:30 ` [U-Boot] [PATCH v2 1/2] x86: Add SCU IPC " Simon Glass
2017-03-20 13:27   ` Andy Shevchenko [this message]
2017-03-26 12:01     ` Andy Shevchenko
2017-04-01  4:24       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490016429.19767.113.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox