public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors
Date: Fri, 24 Mar 2017 11:08:13 +0000	[thread overview]
Message-ID: <1490353692.5689.2.camel@synopsys.com> (raw)
In-Reply-To: <c80226dc-8d90-be44-3b39-b2be18e38920@denx.de>

Hi Marek,

On Sun, 2017-03-05 at 02:09 +0100, Marek Vasut wrote:
> On 03/03/2017 02:22 PM, Alexey Brodkin wrote:
> > 
> > Hi Marek,
> > 
> > On Fri, 2017-03-03 at 00:57 +0100, Marek Vasut wrote:
> > > 
> > > On 03/01/2017 01:52 PM, Alexey Brodkin wrote:
> > > > 
> > > > 
> > > > Hi Marek,
> > > > 
> > > > On Fri, 2017-02-10 at 21:33 +0100, Marek Vasut wrote:
> > > > > 
> > > > > 
> > > > > On 02/10/2017 09:23 PM, Alexey Brodkin wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > Current implementation doesn't allow utilization of platform-specific
> > > > > > reads and writes.
> > > > > > 
> > > > > > But some arches or platforms may want to use their accessors that do
> > > > > > some extra work like adding barriers for data serialization etc.
> > > > > > 
> > > > > > Interesting enough OHCI accessors already do that so just aligning
> > > > > > EHCI to it now.
> > > > > > 
> > > > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > > > Cc: Marek Vasut <marex@denx.de>
> > > > > > Cc: Simon Glass <sjg@chromium.org>
> > > > > > Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> > > > > 
> > > > > IMO looks OK,
> > > > > 
> > > > > Acked-by: Marek Vasut <marex@denx.de>
> > > > > 
> > > > > I'd like to have a few more reviews of this before applying it for
> > > > > 2017.05 . Also CCing Wills, it'd be great to get a test on atheros
> > > > > MIPS .
> > > > 
> > > > It's been quite some time since your request to try the patch
> > > > on other systems and so far nobody answered. May we consider that
> > > > one for application then?
> > > > 
> > > > Essentially I'm not talking about current Tom's master branch
> > > > but would be good if the patch lands somewhere and once 2017.03
> > > > gets cut is merged in the main branch?
> > > 
> > > Yeah, it's not happening for 2017.03, it'll go into the next one.
> > > 
> > > Can you just rebase and repost the patch please ? I'll get to it next
> > > week, I'm traveling until the 10th.
> > 
> > I just tried and the same .mbox applies cleanly on top of today's
> > U-Boot master so I believe there's no point in resending it.
> > 
> > Are you OK to just grab existing one?
> 
> I no longer have the patch in my mailbox, which is why I asked you to 
> resend it. Moreover, did you just test that it applies or did you 
> actually build-test and retest the patch on real hardware too ?

I did test it on my boards again on top of today's master branch and
everything seem to work perfectly fine so please consider applying this one.

You may use mbox from here http://patchwork.ozlabs.org/patch/726714/mbox/
Al least it worked for me this way:
--------------------->8-----------------------
curl http://patchwork.ozlabs.org/patch/726714/mbox/ | git am
--------------------->8-----------------------

Regards,
Alexey

  reply	other threads:[~2017-03-24 11:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 20:23 [U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors Alexey Brodkin
2017-02-10 20:33 ` Marek Vasut
2017-03-01 12:52   ` Alexey Brodkin
2017-03-02 23:57     ` Marek Vasut
2017-03-03 13:22       ` Alexey Brodkin
2017-03-05  1:09         ` Marek Vasut
2017-03-24 11:08           ` Alexey Brodkin [this message]
2017-03-24 12:56             ` Marek Vasut
2017-04-14 14:44               ` Marek Vasut
2017-04-14 17:16                 ` Alexey Brodkin
2017-04-14 18:50                   ` Marek Vasut
2017-04-14 20:06                   ` Tom Rini
2017-04-17 16:19                     ` Alexey Brodkin
2017-04-17 16:31                       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490353692.5689.2.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox