public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] regression: setting the rpi mac address stopped working
Date: Mon, 27 Mar 2017 10:24:49 +0200	[thread overview]
Message-ID: <1490603089.31035.24.camel@redhat.com> (raw)

  Hi,

u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
any more, so the linux kernel picks a random mac address.  Bisected to
this commit:

commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
Author: Simon Glass <sjg@chromium.org>
Date:   Wed Oct 5 20:42:11 2016 -0600

    Fix return value in trailing_strtoln()
    
    This function should return -1 if there is no trailing integer
    in the string. Instead it returns 0. Fix it by checking for this
    condition at the start.
    
    Signed-off-by: Simon Glass <sjg@chromium.org>
    Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Appearently this change broke fdt_fixup_ethernet().

cheers,
  Gerd

             reply	other threads:[~2017-03-27  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  8:24 Gerd Hoffmann [this message]
2017-04-01  4:22 ` [U-Boot] regression: setting the rpi mac address stopped working Simon Glass
2017-04-01 14:49   ` Tuomas Tynkkynen
2017-04-24 12:12     ` Gerd Hoffmann
2017-04-26 19:30       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490603089.31035.24.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox