public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: socfpga: Fix broken implementation and enhancing boot header
Date: Wed, 29 Mar 2017 01:02:40 +0000	[thread overview]
Message-ID: <1490749360.10114.0.camel@intel.com> (raw)
In-Reply-To: <4f93ac29-96a9-537d-5e09-5471d5534edb@denx.de>

On Sel, 2017-03-28 at 11:38 +0200, Marek Vasut wrote:
> On 03/28/2017 11:25 AM, tien.fong.chee at intel.com wrote:
> > 
> > From: "Chee, Tien Fong" <tien.fong.chee@intel.com>
> > 
> > Fixing the broken implementation caused by the patch
> > commit:ce62e57fc57177352a02b76dace0173bd13404b6, ARM: boot0 hook:
> See section 2) here [1] , in particular the part about referencing
> commits and the Fixes: tag .
> 
> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches
> .html
> 
> > 
> > remove macro, include whole header file. This patch also enhances
> > boot header to contain more special data.
> This should be a separate patch then.
> 
okay. Thanks.
> > 
> > Signed-off-by: Chee, Tien Fong <tien.fong.chee@intel.com>
> > ---
> >  arch/arm/mach-socfpga/include/mach/boot0.h | 30 ++++++++++++++++
> > --------------
> >  1 file changed, 16 insertions(+), 14 deletions(-)
> > 
> > diff --git a/arch/arm/mach-socfpga/include/mach/boot0.h
> > b/arch/arm/mach-socfpga/include/mach/boot0.h
> > index aaada31..877866a 100644
> > --- a/arch/arm/mach-socfpga/include/mach/boot0.h
> > +++ b/arch/arm/mach-socfpga/include/mach/boot0.h
> > @@ -8,21 +8,23 @@
> >  #define __BOOT0_H
> >  
> >  #ifdef CONFIG_SPL_BUILD
> > -#define ARM_SOC_BOOT0_HOOK						
> > \
> > -	.balignl 64,0xf33db33f;					
> > 	\
> > -									
> > \
> > -	.word	0x1337c0d3;	/* SoCFPGA preloader
> > validation word */	\
> > -	.word	0xc01df00d;	/* Version, flags, length
> > */		\
> > -	.word	0xcafec0d3;	/* Checksum, zero-pad */	
> > 	\
> > -	nop;							
> > 	\
> > -									
> > \
> > -	b reset;		/* SoCFPGA jumps here */		
> > \
> > -	nop;							
> > 	\
> > -	nop;							
> > 	\
> > -	nop;
> > -#else
> > -#define ARM_SOC_BOOT0_HOOK
> > +	.balignl 64,0xf33db33f;
> > +
> > +	/* Start of header offset */
> > +	.word	0x1337c0d3; /* SoCFPGA preloader validation
> > word(4B) */
> > +	.word	0xc01df00d; /* Header
> > length(2B),flags(1B),version(1B) */
> > +#ifndef CONFIG_TARGET_SOCFPGA_GEN5
> > +	.word	0xcafec0d3; /* Program length(4B) */
> > +	.word	0xf00dcafe; /* Program entry
> > offset(4B),relative to  */
> > +			    /* the start of program header */
> >  #endif
> > +	.word	0xfeedface; /* Simple checksum(2B),spare
> > offset(2B) */
> > +	nop;
> >  
> > +	b reset;	    /* SoCFPGA jumps here */
> > +	nop;
> > +	nop;
> > +	nop;
> > +#endif
> >  
> >  #endif /* __BOOT0_H */
> > 
> 

      reply	other threads:[~2017-03-29  1:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  9:25 [U-Boot] [PATCH] ARM: socfpga: Fix broken implementation and enhancing boot header tien.fong.chee at intel.com
2017-03-28  9:38 ` Marek Vasut
2017-03-29  1:02   ` Chee, Tien Fong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490749360.10114.0.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox