From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Remove global variable env_t *env_ptr ?
Date: Mon, 3 Apr 2017 12:19:32 +0000 [thread overview]
Message-ID: <1491221969.4177.81.camel@infinera.com> (raw)
I am looking at adding support for runtime sizing of CONFIG_ENV_ADDR as
we need to replace out flash but we don't want to create a new u-boot binairy
just for this simple change.
While converting env_flash.c I noted the global variable
env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR;
which cannot be runtime decided.
Looking at users of this variable I only find one in pmc405de.c(not sure what that board is doing)
and for what I can tell this variable is not correct for redundant env. either.
Anyhow, I am faced wit two choices, either remove the env_ptr or
convert it to a function call.
What do fellow u-booters think about env_ptr?
Jocke
PS. Adding my work so far here:
next reply other threads:[~2017-04-03 12:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 12:19 Joakim Tjernlund [this message]
2017-04-03 20:17 ` [U-Boot] Remove global variable env_t *env_ptr ? Wolfgang Denk
2017-04-04 8:17 ` Joakim Tjernlund
2017-04-04 10:29 ` Wolfgang Denk
2017-04-04 8:55 ` Lukasz Majewski
2017-04-04 10:24 ` Joakim Tjernlund
2017-04-04 10:31 ` Wolfgang Denk
2017-04-04 10:44 ` Joakim Tjernlund
2017-04-04 11:27 ` Wolfgang Denk
2017-04-04 13:21 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491221969.4177.81.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox