public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Ondřej Jirman" <megous@megous.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] Re: [PATCH] sunxi: set up PLL1 on sun6i+ without use dividers
Date: Mon, 10 Apr 2017 12:06:27 +0200	[thread overview]
Message-ID: <1491818787.14386.2.camel@megous.com> (raw)
In-Reply-To: <20170410065901.nhcree7fuv7k3puv@lukather>

Hi Maxime,

Maxime Ripard píše v Po 10. 04. 2017 v 08:59 +0200:
> On Mon, Apr 10, 2017 at 12:19:41AM +0800, Icenowy Zheng wrote:
> > According to the researching result of Ondrej Jirman, the factor M of
> > PLL1 shouldn't be used and the factor P should be used only if the
> > intended frequency is lower than 288MHz. This is proven by the
> > clk-sun8iw7_tbl.c in the BSP source code -- in there the M value is
> > always 0 and the maximum frequency that P is not 0 is 224MHz.
> > 
> > As P is ignored on sun6i, it's not currently used. This patch removed
> > the usage of M.
> > 
> > This patch is an original work by Ondrej Jirman, however, he didn't add
> > a Signed-off-by tag here to his commit. So I take this code and added my
> > Signed-off-by.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> > 
> > This is a critical patch, and should be added to 2017.05.
> > 
> > It has been verified by the Armbian.
> 
> This doesn't mean anything. How has this been verified?

We already discussed this here: https://patchwork.kernel.org/patch/9446
365/

regards,
  o.j.

> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170410/ac718063/attachment.sig>

  parent reply	other threads:[~2017-04-10 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-09 16:19 [U-Boot] [PATCH] sunxi: set up PLL1 on sun6i+ without use dividers Icenowy Zheng
2017-04-09 16:24 ` [U-Boot] [linux-sunxi] " Vincent Legoll
2017-04-10  6:59 ` [U-Boot] " Maxime Ripard
2017-04-10  8:43   ` icenowy at aosc.io
2017-04-11  9:17     ` Maxime Ripard
2017-04-10 10:06   ` Ondřej Jirman [this message]
2017-04-10 10:15     ` [U-Boot] [linux-sunxi] " icenowy at aosc.io
2017-04-10 10:33       ` Ondřej Jirman
2017-04-11  9:18     ` Maxime Ripard
2017-04-10 10:27 ` [U-Boot] [linux-sunxi] " Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491818787.14386.2.camel@megous.com \
    --to=megous@megous.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox