From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] fs: fix do_fsload() handling of optional arguments
Date: Tue, 30 Oct 2012 23:28:55 +0100 (CET) [thread overview]
Message-ID: <149240252.289542.1351636135124.JavaMail.root@advansee.com> (raw)
In-Reply-To: <1351634659-16107-1-git-send-email-swarren@wwwdotorg.org>
On Tuesday, October 30, 2012 11:04:17 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Most arguments to the shell command do_fsload() implements are
> optional.
> Fix the minimum argc check to respect that. Cater for the situation
> where argv[2] is not provided.
>
> Enhance both do_fsload() and do_ls() to check the maximum number of
> arguments too. While this check would typically be implemented via
> U_BOOT_CMD()'s max_args parameter, if these functions are called
> directly, then that check won't exist.
>
> Finally, alter do_ls() to check (argc >= 4) rather than (argc == 4)
> so
> that if the function is enhanced to allow extra arguments in the
> future,
> this test won't need to be changed at that time.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
[--snip--]
For the series:
Reviewed-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Best regards,
Beno?t
next prev parent reply other threads:[~2012-10-30 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 22:04 [U-Boot] [PATCH 1/3] fs: fix do_fsload() handling of optional arguments Stephen Warren
2012-10-30 22:04 ` [U-Boot] [PATCH 2/3] cmd_ext4: remove TABs from command help text Stephen Warren
2012-10-30 22:04 ` [U-Boot] [PATCH 3/3] fs: fix number base behaviour change in fatload/ext*load Stephen Warren
2012-10-30 22:28 ` Benoît Thébaudeau [this message]
2012-11-04 18:30 ` [U-Boot] [PATCH 1/3] fs: fix do_fsload() handling of optional arguments Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149240252.289542.1351636135124.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox