From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Tue, 30 Oct 2012 23:28:55 +0100 (CET) Subject: [U-Boot] [PATCH 1/3] fs: fix do_fsload() handling of optional arguments In-Reply-To: <1351634659-16107-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <149240252.289542.1351636135124.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, October 30, 2012 11:04:17 PM, Stephen Warren wrote: > From: Stephen Warren > > Most arguments to the shell command do_fsload() implements are > optional. > Fix the minimum argc check to respect that. Cater for the situation > where argv[2] is not provided. > > Enhance both do_fsload() and do_ls() to check the maximum number of > arguments too. While this check would typically be implemented via > U_BOOT_CMD()'s max_args parameter, if these functions are called > directly, then that check won't exist. > > Finally, alter do_ls() to check (argc >= 4) rather than (argc == 4) > so > that if the function is enhanced to allow extra arguments in the > future, > this test won't need to be changed at that time. > > Signed-off-by: Stephen Warren [--snip--] For the series: Reviewed-by: Beno?t Th?baudeau Best regards, Beno?t