public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors
Date: Mon, 17 Apr 2017 16:19:17 +0000	[thread overview]
Message-ID: <1492445956.7458.16.camel@synopsys.com> (raw)
In-Reply-To: <20170414200605.GU19897@bill-the-cat>

Hi Tom, Marek,

On Fri, 2017-04-14 at 16:06 -0400, Tom Rini wrote:
> On Fri, Apr 14, 2017 at 05:16:11PM +0000, Alexey Brodkin wrote:
> > 
> > Hi Marek,
> > 
> > On Fri, 2017-04-14 at 16:44 +0200, Marek Vasut wrote:
> > > 
> > > On 03/24/2017 01:56 PM, Marek Vasut wrote:
> > > > 
> > > >  
> > > Even better, this patch breaks powerpc board lwmon5, so dropped.
> > 
> > Are you sure the problem is in my patch?
> 
> Yes, it is.  Dropping this from the USB PR gets everything going again.

Ok the problem was obvious missing inclusion f "asm/io.h".
Fix is submitted here http://patchwork.ozlabs.org/patch/751397/

Please consider for applying.

> > Maybe this PPC board just needs to UNdefine
> > CONFIG_EHCI_DESC_BIG_ENDIAN or there's a problem in its either
> > cpu_to_XXX() or readl()/writel()?
> > 
> > Stefan, could you please look at what's wrong here
> > if you have the board handy?
> 
> Well, since this is your set of changes, you should have some idea
> what's right/wrong here given what things are before/after.  Also, for
> wide changes like this, please give things a build either in travis-ci
> (so that most of the world is built) or do most of the world locally
> before posting, thanks!

Well I tried to run a buildman locally (thanks to machine resources I have)
but out of 1243 boards 154 have fatal problems if I use toolchains obtained
via buildbot. Which is barely useful for capturing issues introduced by
incremental patches :(

-Alexey

  reply	other threads:[~2017-04-17 16:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 20:23 [U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors Alexey Brodkin
2017-02-10 20:33 ` Marek Vasut
2017-03-01 12:52   ` Alexey Brodkin
2017-03-02 23:57     ` Marek Vasut
2017-03-03 13:22       ` Alexey Brodkin
2017-03-05  1:09         ` Marek Vasut
2017-03-24 11:08           ` Alexey Brodkin
2017-03-24 12:56             ` Marek Vasut
2017-04-14 14:44               ` Marek Vasut
2017-04-14 17:16                 ` Alexey Brodkin
2017-04-14 18:50                   ` Marek Vasut
2017-04-14 20:06                   ` Tom Rini
2017-04-17 16:19                     ` Alexey Brodkin [this message]
2017-04-17 16:31                       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492445956.7458.16.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox