From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Mon, 17 Apr 2017 16:19:17 +0000 Subject: [U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors In-Reply-To: <20170414200605.GU19897@bill-the-cat> References: <1486758216-23140-1-git-send-email-abrodkin@synopsys.com> <1b780ba5-f754-e681-758e-3d8bc9b7a70d@denx.de> <1488372733.4659.19.camel@synopsys.com> <2004fcc3-7ae2-209e-957d-48eadc588b12@denx.de> <1488547367.2940.1.camel@synopsys.com> <1490353692.5689.2.camel@synopsys.com> <1c621928-7149-59a6-9a6b-c08109c3dd3a@denx.de> <1492190170.3223.25.camel@synopsys.com> <20170414200605.GU19897@bill-the-cat> Message-ID: <1492445956.7458.16.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Tom, Marek, On Fri, 2017-04-14 at 16:06 -0400, Tom Rini wrote: > On Fri, Apr 14, 2017 at 05:16:11PM +0000, Alexey Brodkin wrote: > > > > Hi Marek, > > > > On Fri, 2017-04-14 at 16:44 +0200, Marek Vasut wrote: > > > > > > On 03/24/2017 01:56 PM, Marek Vasut wrote: > > > > > > > >   > > > Even better, this patch breaks powerpc board lwmon5, so dropped. > > > > Are you sure the problem is in my patch? > > Yes, it is.  Dropping this from the USB PR gets everything going again. Ok the problem was obvious missing inclusion f "asm/io.h". Fix is submitted here http://patchwork.ozlabs.org/patch/751397/ Please consider for applying. > > Maybe this PPC board just needs to UNdefine > > CONFIG_EHCI_DESC_BIG_ENDIAN or there's a problem in its either > > cpu_to_XXX() or readl()/writel()? > > > > Stefan, could you please look at what's wrong here > > if you have the board handy? > > Well, since this is your set of changes, you should have some idea > what's right/wrong here given what things are before/after.  Also, for > wide changes like this, please give things a build either in travis-ci > (so that most of the world is built) or do most of the world locally > before posting, thanks! Well I tried to run a buildman locally (thanks to machine resources I have) but out of 1243 boards 154 have fatal problems if I use toolchains obtained via buildbot. Which is barely useful for capturing issues introduced by incremental patches :( -Alexey