[U-Boot] [PATCH v2 04/14] serial: add serial driver for BCM6345

Simon Glass
2017-04-16T19:34:18Z

On 15 April 2017 at 16:03, Álvaro Fernández Rojas <noltari@gmail.com> wrote:
> It is based on linux/drivers/tty/serial/bcm63xx_uart.c
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v2: Introduce changes suggested by Daniel Schwierzeck:
> - Remove unneeded defines.
> - Fix incorrect multi-line comment.
>
> drivers/serial/Kconfig | 14 +++
> drivers/serial/Makefile | 1 +
> drivers/serial/serial_bcm6345.c | 267 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 282 insertions(+)
> create mode 100644 drivers/serial/serial_bcm6345.c

Reviewed-by: Simon Glass <sjg@chromium.org>

IMO the raw read/write are ugly. It is better to use clrsetbits etc.
than lots of read/write calls. Also we tend to use C structs to access
registers although that is not required now.

I cannot see a lot of point in trying to make it look like the Linux
driver. Is that driver changing rapidly and hard to track?