[U-Boot] Pull request: u-boot-spi/next

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

Hi Tom,

Please take this PR.

thanks!
Jagan.

The following changes since commit ac6991fb5fc1a694b29f4ebd5e07baebf818d7cc:

  zynq: spi: Honour the activation / deactivation delay (2017-05-03 11:03:04 +0530)

are available in the git repository at:

  git://git.denx.de/u-boot-spi.git next

for you to fetch changes up to 0b2e5bbe6a4f3d25522675198b8beb0093a2e750:

  env_sf: use DIV_ROUND_UP to calculate number of sectors to erase (2017-05-03 11:18:20 +0530)

----------------------------------------------------------------
Andreas Fenkart (4):
      env_sf: factor out prepare_flash_device
      enf_sf: reuse setup_flash_device instead of open coding it
      env_sf: re-order error handling in single-buffer env_relocate_spec
      env_sf: use DIV_ROUND_UP to calculate number of sectors to erase

 common/env_sf.c | 92 ++++++++++++++++++++++-----------------------------------
 1 file changed, 36 insertions(+), 56 deletions(-)

[U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Mon, May 08, 2017 at 09:46:41PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit ac6991fb5fc1a694b29f4ebd5e07baebf818d7cc:
> 
>   zynq: spi: Honour the activation / deactivation delay (2017-05-03 11:03:04 +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git next
> 
> for you to fetch changes up to 0b2e5bbe6a4f3d25522675198b8beb0093a2e750:
> 
>   env_sf: use DIV_ROUND_UP to calculate number of sectors to erase (2017-05-03 11:18:20 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170508/8d5bfdc0/attachment.sig>

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit 312db9f75f50b339310474d72c8524cef2bd7931:

  armv7: omap-common: Rework SPL board_mmc_init() (2015-12-14 13:42:54 -0500)

are available in the git repository at:

  git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 25aade812e40f2e869575199c64e35ebcdf5554b:

  defconfig: am437x_sk_evm: enable spi driver model (2015-12-29 13:27:46 +0530)

----------------------------------------------------------------
Jagan Teki (24):
      sf: Get spi locally from spi_flash
      spi: make mode visible to both dm and non-dm
      spi: Use mode instead of op_mode_tx
      spi: Rename SPI_TX_BP|QPP to SPI_TX_BYTE|QUAD
      sf: Move spi_read_cmds_array locally
      sf: Rename spi_flash_set_* functions
      sf: Rename bank_end to bar_end in read_bar
      sf: Remove spi_flash_remove
      sf: Minor cleanup
      sf: Use BIT macro
      sf: Fix quad bit set for micron devices
      sf: Read back and check once spansion quad bit set
      sf: Read back and check once macronix quad bit set
      sf: Write quad bit along with read status
      spi: Remove SPI_OPM_RX_EXTN
      spi: Remove SPI_OPM_RX_DIO|QIOF
      spi: Rename SPI_OPM_RX_* to SPI_RX_*
      spi: Rename op_mode_rx to mode_rx
      spi: Move flags macro's to spi_slave{} members
      spi: Fix bit assignment with flags
      spi: Use BIT macro
      spi: Minor cleanup
      sf: Make IO modes at last in read modes
      spi: Add SPI_TX_DUAL mode

Mugunthan V N (17):
      drivers: spi: ti_qspi: do not hard code chip select for memory map configuration
      drivers: spi:ti_qspi: change ti_qspi_slave to ti_qspi_priv for driver model conversion
      drivers: spi: ti_qspi: prepare driver for DM conversion
      dm: core: Add a new api to get indexed device address
      spi: Add support for dual and quad mode
      dra7xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
      dts: dra7: add spi alias for qspi
      drivers: spi: ti_qspi: convert driver to adopt device driver model
      arm: dts: dra7: add qspi register maps for memory map and control module
      arm: dts: am437x-gp-evm: add spi-flash comaptible for flash
      arm: dts: dra7-evm: add spi-flash comaptible for flash
      arm: dts: dra72-evm: add spi-flash comaptible for flash
      defconfig: dra72_evm: enable spi driver model
      defconfig: dra74_evm: enable spi driver model
      am43xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
      arm: dts: am4372: add qspi register maps for memory map
      defconfig: am437x_sk_evm: enable spi driver model

 arch/arm/dts/am4372.dtsi        |   5 +-
 arch/arm/dts/am437x-sk-evm.dts  |   2 +-
 arch/arm/dts/dra7-evm.dts       |   2 +-
 arch/arm/dts/dra7.dtsi          |   8 +-
 arch/arm/dts/dra72-evm.dts      |   2 +-
 configs/am437x_sk_evm_defconfig |   3 +
 configs/dra72_evm_defconfig     |   2 +
 configs/dra74_evm_defconfig     |   2 +
 drivers/core/device.c           |  31 ++-
 drivers/mtd/spi/sf-uclass.c     |   7 +-
 drivers/mtd/spi/sf_internal.h   |  55 +++--
 drivers/mtd/spi/sf_probe.c      |   2 +-
 drivers/mtd/spi/spi_flash.c     | 185 +++++++++-----
 drivers/spi/ich.c               |   4 +-
 drivers/spi/spi-uclass.c        |  38 ++-
 drivers/spi/ti_qspi.c           | 524 ++++++++++++++++++++++++++++------------
 include/configs/am43xx_evm.h    |   2 +
 include/configs/dra7xx_evm.h    |   5 +
 include/dm/device.h             |  11 +
 include/spi.h                   |  75 +++---
 include/spi_flash.h             |   2 -
 21 files changed, 667 insertions(+), 300 deletions(-)

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

Tom,

Please note that subject shows u-boot-spi/next but it actually
u-boot-spi/master and of course PR shows the repo as master (not
next).

On 30 December 2015 at 16:01, Jagan Teki <jteki@openedev.com> wrote:
> Hi Tom,
>
> Please pull this PR.
>
> thanks!
> Jagan.
>
> The following changes since commit 312db9f75f50b339310474d72c8524cef2bd7931:
>
>   armv7: omap-common: Rework SPL board_mmc_init() (2015-12-14 13:42:54 -0500)
>
> are available in the git repository at:
>
>   git://git.denx.de/u-boot-spi.git master
>
> for you to fetch changes up to 25aade812e40f2e869575199c64e35ebcdf5554b:
>
>   defconfig: am437x_sk_evm: enable spi driver model (2015-12-29 13:27:46 +0530)
>
> ----------------------------------------------------------------
> Jagan Teki (24):
>       sf: Get spi locally from spi_flash
>       spi: make mode visible to both dm and non-dm
>       spi: Use mode instead of op_mode_tx
>       spi: Rename SPI_TX_BP|QPP to SPI_TX_BYTE|QUAD
>       sf: Move spi_read_cmds_array locally
>       sf: Rename spi_flash_set_* functions
>       sf: Rename bank_end to bar_end in read_bar
>       sf: Remove spi_flash_remove
>       sf: Minor cleanup
>       sf: Use BIT macro
>       sf: Fix quad bit set for micron devices
>       sf: Read back and check once spansion quad bit set
>       sf: Read back and check once macronix quad bit set
>       sf: Write quad bit along with read status
>       spi: Remove SPI_OPM_RX_EXTN
>       spi: Remove SPI_OPM_RX_DIO|QIOF
>       spi: Rename SPI_OPM_RX_* to SPI_RX_*
>       spi: Rename op_mode_rx to mode_rx
>       spi: Move flags macro's to spi_slave{} members
>       spi: Fix bit assignment with flags
>       spi: Use BIT macro
>       spi: Minor cleanup
>       sf: Make IO modes at last in read modes
>       spi: Add SPI_TX_DUAL mode
>
> Mugunthan V N (17):
>       drivers: spi: ti_qspi: do not hard code chip select for memory map configuration
>       drivers: spi:ti_qspi: change ti_qspi_slave to ti_qspi_priv for driver model conversion
>       drivers: spi: ti_qspi: prepare driver for DM conversion
>       dm: core: Add a new api to get indexed device address
>       spi: Add support for dual and quad mode
>       dra7xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
>       dts: dra7: add spi alias for qspi
>       drivers: spi: ti_qspi: convert driver to adopt device driver model
>       arm: dts: dra7: add qspi register maps for memory map and control module
>       arm: dts: am437x-gp-evm: add spi-flash comaptible for flash
>       arm: dts: dra7-evm: add spi-flash comaptible for flash
>       arm: dts: dra72-evm: add spi-flash comaptible for flash
>       defconfig: dra72_evm: enable spi driver model
>       defconfig: dra74_evm: enable spi driver model
>       am43xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
>       arm: dts: am4372: add qspi register maps for memory map
>       defconfig: am437x_sk_evm: enable spi driver model
>
>  arch/arm/dts/am4372.dtsi        |   5 +-
>  arch/arm/dts/am437x-sk-evm.dts  |   2 +-
>  arch/arm/dts/dra7-evm.dts       |   2 +-
>  arch/arm/dts/dra7.dtsi          |   8 +-
>  arch/arm/dts/dra72-evm.dts      |   2 +-
>  configs/am437x_sk_evm_defconfig |   3 +
>  configs/dra72_evm_defconfig     |   2 +
>  configs/dra74_evm_defconfig     |   2 +
>  drivers/core/device.c           |  31 ++-
>  drivers/mtd/spi/sf-uclass.c     |   7 +-
>  drivers/mtd/spi/sf_internal.h   |  55 +++--
>  drivers/mtd/spi/sf_probe.c      |   2 +-
>  drivers/mtd/spi/spi_flash.c     | 185 +++++++++-----
>  drivers/spi/ich.c               |   4 +-
>  drivers/spi/spi-uclass.c        |  38 ++-
>  drivers/spi/ti_qspi.c           | 524 ++++++++++++++++++++++++++++------------
>  include/configs/am43xx_evm.h    |   2 +
>  include/configs/dra7xx_evm.h    |   5 +
>  include/dm/device.h             |  11 +
>  include/spi.h                   |  75 +++---
>  include/spi_flash.h             |   2 -
>  21 files changed, 667 insertions(+), 300 deletions(-)

thanks!
-- 
Jagan.

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

On 30 December 2015 at 16:04, Jagan Teki <jteki@openedev.com> wrote:
> Tom,

Please pull this asap, in case if you miss.

>
> Please note that subject shows u-boot-spi/next but it actually
> u-boot-spi/master and of course PR shows the repo as master (not
> next).
>
> On 30 December 2015 at 16:01, Jagan Teki <jteki@openedev.com> wrote:
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 312db9f75f50b339310474d72c8524cef2bd7931:
>>
>>   armv7: omap-common: Rework SPL board_mmc_init() (2015-12-14 13:42:54 -0500)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 25aade812e40f2e869575199c64e35ebcdf5554b:
>>
>>   defconfig: am437x_sk_evm: enable spi driver model (2015-12-29 13:27:46 +0530)
>>
>> ----------------------------------------------------------------
>> Jagan Teki (24):
>>       sf: Get spi locally from spi_flash
>>       spi: make mode visible to both dm and non-dm
>>       spi: Use mode instead of op_mode_tx
>>       spi: Rename SPI_TX_BP|QPP to SPI_TX_BYTE|QUAD
>>       sf: Move spi_read_cmds_array locally
>>       sf: Rename spi_flash_set_* functions
>>       sf: Rename bank_end to bar_end in read_bar
>>       sf: Remove spi_flash_remove
>>       sf: Minor cleanup
>>       sf: Use BIT macro
>>       sf: Fix quad bit set for micron devices
>>       sf: Read back and check once spansion quad bit set
>>       sf: Read back and check once macronix quad bit set
>>       sf: Write quad bit along with read status
>>       spi: Remove SPI_OPM_RX_EXTN
>>       spi: Remove SPI_OPM_RX_DIO|QIOF
>>       spi: Rename SPI_OPM_RX_* to SPI_RX_*
>>       spi: Rename op_mode_rx to mode_rx
>>       spi: Move flags macro's to spi_slave{} members
>>       spi: Fix bit assignment with flags
>>       spi: Use BIT macro
>>       spi: Minor cleanup
>>       sf: Make IO modes at last in read modes
>>       spi: Add SPI_TX_DUAL mode
>>
>> Mugunthan V N (17):
>>       drivers: spi: ti_qspi: do not hard code chip select for memory map configuration
>>       drivers: spi:ti_qspi: change ti_qspi_slave to ti_qspi_priv for driver model conversion
>>       drivers: spi: ti_qspi: prepare driver for DM conversion
>>       dm: core: Add a new api to get indexed device address
>>       spi: Add support for dual and quad mode
>>       dra7xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
>>       dts: dra7: add spi alias for qspi
>>       drivers: spi: ti_qspi: convert driver to adopt device driver model
>>       arm: dts: dra7: add qspi register maps for memory map and control module
>>       arm: dts: am437x-gp-evm: add spi-flash comaptible for flash
>>       arm: dts: dra7-evm: add spi-flash comaptible for flash
>>       arm: dts: dra72-evm: add spi-flash comaptible for flash
>>       defconfig: dra72_evm: enable spi driver model
>>       defconfig: dra74_evm: enable spi driver model
>>       am43xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl
>>       arm: dts: am4372: add qspi register maps for memory map
>>       defconfig: am437x_sk_evm: enable spi driver model
>>
>>  arch/arm/dts/am4372.dtsi        |   5 +-
>>  arch/arm/dts/am437x-sk-evm.dts  |   2 +-
>>  arch/arm/dts/dra7-evm.dts       |   2 +-
>>  arch/arm/dts/dra7.dtsi          |   8 +-
>>  arch/arm/dts/dra72-evm.dts      |   2 +-
>>  configs/am437x_sk_evm_defconfig |   3 +
>>  configs/dra72_evm_defconfig     |   2 +
>>  configs/dra74_evm_defconfig     |   2 +
>>  drivers/core/device.c           |  31 ++-
>>  drivers/mtd/spi/sf-uclass.c     |   7 +-
>>  drivers/mtd/spi/sf_internal.h   |  55 +++--
>>  drivers/mtd/spi/sf_probe.c      |   2 +-
>>  drivers/mtd/spi/spi_flash.c     | 185 +++++++++-----
>>  drivers/spi/ich.c               |   4 +-
>>  drivers/spi/spi-uclass.c        |  38 ++-
>>  drivers/spi/ti_qspi.c           | 524 ++++++++++++++++++++++++++++------------
>>  include/configs/am43xx_evm.h    |   2 +
>>  include/configs/dra7xx_evm.h    |   5 +
>>  include/dm/device.h             |  11 +
>>  include/spi.h                   |  75 +++---
>>  include/spi_flash.h             |   2 -
>>  21 files changed, 667 insertions(+), 300 deletions(-)
>
> thanks!
> --
> Jagan.



-- 
Jagan.

[U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:

> Tom,
> 
> Please note that subject shows u-boot-spi/next but it actually
> u-boot-spi/master and of course PR shows the repo as master (not
> next).

OK, what in here is a clear bugfix rather than new feature that we
should have taken in sooner?  As-is this needs some rework on samsung
stuff to make trats, trats2 and s5pc210_universal work.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160102/024415ed/attachment.sig>

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

On 2 January 2016 at 22:34, Tom Rini <trini@konsulko.com> wrote:
> On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:
>
>> Tom,
>>
>> Please note that subject shows u-boot-spi/next but it actually
>> u-boot-spi/master and of course PR shows the repo as master (not
>> next).
>
> OK, what in here is a clear bugfix rather than new feature that we
> should have taken in sooner?  As-is this needs some rework on samsung
> stuff to make trats, trats2 and s5pc210_universal work.  Thanks!

How come these sf and ti patches are blocking these samsung boards to
work? few of these were bug fixes and others were features (ti
patches) but those initiated in last MW.

thanks!
-- 
Jagan.

[U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Sun, Jan 03, 2016 at 09:26:38AM +0530, Jagan Teki wrote:
> On 2 January 2016 at 22:34, Tom Rini <trini@konsulko.com> wrote:
> > On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:
> >
> >> Tom,
> >>
> >> Please note that subject shows u-boot-spi/next but it actually
> >> u-boot-spi/master and of course PR shows the repo as master (not
> >> next).
> >
> > OK, what in here is a clear bugfix rather than new feature that we
> > should have taken in sooner?  As-is this needs some rework on samsung
> > stuff to make trats, trats2 and s5pc210_universal work.  Thanks!
> 
> How come these sf and ti patches are blocking these samsung boards to
> work? few of these were bug fixes and others were features (ti
> patches) but those initiated in last MW.

The patch to use BIT() in spi.h causes undefined references on trats2,
hence the first patch I posted in reply to the PR.  This however broke
trats/s5pc210_universal.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160103/a7ea8bc4/attachment.sig>

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

On 3 January 2016 at 20:14, Tom Rini <trini@konsulko.com> wrote:
> On Sun, Jan 03, 2016 at 09:26:38AM +0530, Jagan Teki wrote:
>> On 2 January 2016 at 22:34, Tom Rini <trini@konsulko.com> wrote:
>> > On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:
>> >
>> >> Tom,
>> >>
>> >> Please note that subject shows u-boot-spi/next but it actually
>> >> u-boot-spi/master and of course PR shows the repo as master (not
>> >> next).
>> >
>> > OK, what in here is a clear bugfix rather than new feature that we
>> > should have taken in sooner?  As-is this needs some rework on samsung
>> > stuff to make trats, trats2 and s5pc210_universal work.  Thanks!
>>
>> How come these sf and ti patches are blocking these samsung boards to
>> work? few of these were bug fixes and others were features (ti
>> patches) but those initiated in last MW.
>
> The patch to use BIT() in spi.h causes undefined references on trats2,
> hence the first patch I posted in reply to the PR.  This however broke
> trats/s5pc210_universal.

Build looks fine for me [1]

[1] http://paste.ubuntu.com/14387171/

-- 
Jagan.

[U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Sun, Jan 03, 2016 at 09:10:14PM +0530, Jagan Teki wrote:
> On 3 January 2016 at 20:14, Tom Rini <trini@konsulko.com> wrote:
> > On Sun, Jan 03, 2016 at 09:26:38AM +0530, Jagan Teki wrote:
> >> On 2 January 2016 at 22:34, Tom Rini <trini@konsulko.com> wrote:
> >> > On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:
> >> >
> >> >> Tom,
> >> >>
> >> >> Please note that subject shows u-boot-spi/next but it actually
> >> >> u-boot-spi/master and of course PR shows the repo as master (not
> >> >> next).
> >> >
> >> > OK, what in here is a clear bugfix rather than new feature that we
> >> > should have taken in sooner?  As-is this needs some rework on samsung
> >> > stuff to make trats, trats2 and s5pc210_universal work.  Thanks!
> >>
> >> How come these sf and ti patches are blocking these samsung boards to
> >> work? few of these were bug fixes and others were features (ti
> >> patches) but those initiated in last MW.
> >
> > The patch to use BIT() in spi.h causes undefined references on trats2,
> > hence the first patch I posted in reply to the PR.  This however broke
> > trats/s5pc210_universal.
> 
> Build looks fine for me [1]
> 
> [1] http://paste.ubuntu.com/14387171/

Yes, that and trats are fine with your series, trats2 is not.  My first
pass at fixing trats2 broke trats/s5p..

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160103/94e50d7d/attachment.sig>

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

On 3 January 2016 at 21:26, Tom Rini <trini@konsulko.com> wrote:
> On Sun, Jan 03, 2016 at 09:10:14PM +0530, Jagan Teki wrote:
>> On 3 January 2016 at 20:14, Tom Rini <trini@konsulko.com> wrote:
>> > On Sun, Jan 03, 2016 at 09:26:38AM +0530, Jagan Teki wrote:
>> >> On 2 January 2016 at 22:34, Tom Rini <trini@konsulko.com> wrote:
>> >> > On Wed, Dec 30, 2015 at 04:04:23PM +0530, Jagan Teki wrote:
>> >> >
>> >> >> Tom,
>> >> >>
>> >> >> Please note that subject shows u-boot-spi/next but it actually
>> >> >> u-boot-spi/master and of course PR shows the repo as master (not
>> >> >> next).
>> >> >
>> >> > OK, what in here is a clear bugfix rather than new feature that we
>> >> > should have taken in sooner?  As-is this needs some rework on samsung
>> >> > stuff to make trats, trats2 and s5pc210_universal work.  Thanks!
>> >>
>> >> How come these sf and ti patches are blocking these samsung boards to
>> >> work? few of these were bug fixes and others were features (ti
>> >> patches) but those initiated in last MW.
>> >
>> > The patch to use BIT() in spi.h causes undefined references on trats2,
>> > hence the first patch I posted in reply to the PR.  This however broke
>> > trats/s5pc210_universal.
>>
>> Build looks fine for me [1]
>>
>> [1] http://paste.ubuntu.com/14387171/
>
> Yes, that and trats are fine with your series, trats2 is not.  My first
> pass at fixing trats2 broke trats/s5p..

The patch "power: pmic.h: Drop include <spi.h>" will fix trats2.

-- 
Jagan.

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

Hi Tom,

Please pull this series.

thanks!
Jagan.

The following changes since commit 96d59e9d6aa74e35c63dc74da10e41f8ba0f6de4:

  mpc85xx/t2081: enable parsing DDR ratio for T2081 rev1.1 (2015-11-02 08:51:50 -0800)

are available in the git repository at:

  git://git.denx.de/u-boot-spi.git next

for you to fetch changes up to e39e68f155b4fcd47f62ab2cf0e199d04f38446d:

  sf: Add SPI NOR protection mechanism (2015-11-03 21:51:37 +0530)

----------------------------------------------------------------
Fabio Estevam (16):
      include: Add log2 header from the kernel
      include: Add generic bitops headers
      ARM: bitops: Use the generic bitops headers
      x86: bitops: Use the generic bitops headers
      m68k: bitops: Use the generic bitops headers
      blackfin: bitops: Use the generic bitops headers
      sh: bitops: Use the generic bitops headers
      sandbox: Use the generic bitops headers
      sparc: Use the generic bitops headers
      openrisc: Use the generic bitops headers
      nds32: Use the generic bitops headers
      nios2: Use the generic bitops headers
      compat: Remove is_power_of_2() definition
      powerpc: Remove __ilog2_u64 and ffs4 from bitops
      sf: Add SPI protection mechanism from the kernel
      sf: Add SPI NOR protection mechanism

 arch/arm/include/asm/bitops.h        |   5 +
 arch/arm/mach-mvebu/mbus.c           |   2 +-
 arch/blackfin/include/asm/bitops.h   |   4 +
 arch/m68k/include/asm/bitops.h       |   4 +
 arch/microblaze/include/asm/bitops.h |   4 +
 arch/nds32/include/asm/bitops.h      |   4 +
 arch/nios2/include/asm/bitops.h      |   5 +
 arch/openrisc/include/asm/bitops.h   |   4 +
 arch/powerpc/cpu/mpc83xx/law.c       |   5 +-
 arch/powerpc/cpu/mpc85xx/tlb.c       |   2 +
 arch/powerpc/cpu/mpc8xxx/law.c       |   5 +-
 arch/powerpc/include/asm/bitops.h    |  11 +-
 arch/powerpc/include/asm/fsl_law.h   |   1 +
 arch/powerpc/include/asm/fsl_srio.h  |   2 +
 arch/sandbox/include/asm/bitops.h    |   4 +
 arch/sh/include/asm/bitops.h         |   5 +
 arch/sparc/include/asm/bitops.h      |   5 +
 arch/x86/include/asm/bitops.h        |  21 +++-
 common/cmd_sf.c                      |  35 ++++++
 drivers/mtd/mtdcore.c                |   2 +-
 drivers/mtd/spi/sf_internal.h        |  12 ++
 drivers/mtd/spi/sf_ops.c             | 180 ++++++++++++++++++++++++++++++
 drivers/mtd/spi/sf_probe.c           |  13 +++
 drivers/mtd/ubi/build.c              |   2 +-
 fs/ubifs/super.c                     |   2 +-
 include/asm-generic/bitops/__ffs.h   |  43 ++++++++
 include/asm-generic/bitops/__fls.h   |  43 ++++++++
 include/asm-generic/bitops/fls.h     |  41 +++++++
 include/asm-generic/bitops/fls64.h   |  36 ++++++
 include/linux/bitops.h               |  27 +++++
 include/linux/compat.h               |   6 -
 include/linux/log2.h                 | 205 +++++++++++++++++++++++++++++++++++
 include/spi_flash.h                  |  19 ++++
 33 files changed, 734 insertions(+), 25 deletions(-)
 create mode 100644 include/asm-generic/bitops/__ffs.h
 create mode 100644 include/asm-generic/bitops/__fls.h
 create mode 100644 include/asm-generic/bitops/fls.h
 create mode 100644 include/asm-generic/bitops/fls64.h
 create mode 100644 include/linux/log2.h

[U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Tue, Nov 03, 2015 at 11:39:56PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this series.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 96d59e9d6aa74e35c63dc74da10e41f8ba0f6de4:
> 
>   mpc85xx/t2081: enable parsing DDR ratio for T2081 rev1.1 (2015-11-02 08:51:50 -0800)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git next
> 
> for you to fetch changes up to e39e68f155b4fcd47f62ab2cf0e199d04f38446d:
> 
>   sf: Add SPI NOR protection mechanism (2015-11-03 21:51:37 +0530)

NAK.

So, this blows up badly for a lot of things when I do:
./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'

And most of these have a toolchain that buildman can fetch, if you don't
have one handy.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151103/1c76522c/attachment.sig>

[U-Boot] Pull request: u-boot-spi/next

[Bin Meng]

Hi Jagan,

On Wed, Nov 4, 2015 at 9:47 AM, Tom Rini <trini@konsulko.com> wrote:
> On Tue, Nov 03, 2015 at 11:39:56PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this series.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 96d59e9d6aa74e35c63dc74da10e41f8ba0f6de4:
>>
>>   mpc85xx/t2081: enable parsing DDR ratio for T2081 rev1.1 (2015-11-02 08:51:50 -0800)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git next
>>
>> for you to fetch changes up to e39e68f155b4fcd47f62ab2cf0e199d04f38446d:
>>
>>   sf: Add SPI NOR protection mechanism (2015-11-03 21:51:37 +0530)
>
> NAK.
>
> So, this blows up badly for a lot of things when I do:
> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>
> And most of these have a toolchain that buildman can fetch, if you don't
> have one handy.
>

I believe you need really use buildman to build the commits. One of
the previous review comments to your patch series was regard to the
'bisectability', and buildman can help you with that.

+Simon for buildman if you want some help.

Regards,
Bin

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:

> NAK.
>
> So, this blows up badly for a lot of things when I do:
> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'

It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.

In the meantime, if you have the build warnings/errors to share it
would be helpful.

Regards,

Fabio Estevam

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

Hi Tom,

On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>
>> NAK.
>>
>> So, this blows up badly for a lot of things when I do:
>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>
> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.

I don't see issues after applying the three attached patches.

Thanks
-------------- next part --------------

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

On Wed, Nov 4, 2015 at 8:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Tom,
>
> On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>>
>>> NAK.
>>>
>>> So, this blows up badly for a lot of things when I do:
>>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>>
>> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.
>
> I don't see issues after applying the three attached patches.

Ops, I do see a build issue in blackfin that didn't happen in previous
versions. Will work on fixing it.

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

Hi Jagan,

On Wed, Nov 4, 2015 at 8:47 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Nov 4, 2015 at 8:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Tom,
>>
>> On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>>>
>>>> NAK.
>>>>
>>>> So, this blows up badly for a lot of things when I do:
>>>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>>>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>>>
>>> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.
>>
>> I don't see issues after applying the three attached patches.
>
> Ops, I do see a build issue in blackfin that didn't happen in previous
> versions. Will work on fixing it.

When you reworked my series you missed to updated these functions:

diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
index 31c79c6..d832464 100644
--- a/drivers/mtd/spi/sf_ops.c
+++ b/drivers/mtd/spi/sf_ops.c
@@ -652,7 +652,7 @@ int stm_is_locked(struct spi_flash *flash, u32
ofs, size_t len)
  *
  * Returns negative on errors, 0 on success.
  */
-int stm_lock(struct spi_flash *flash, u32 ofs, u32 len)
+int stm_lock(struct spi_flash *flash, u32 ofs, size_t len)
 {
     u8 status_old, status_new;
     u8 mask = SR_BP2 | SR_BP1 | SR_BP0;
@@ -703,7 +703,7 @@ int stm_lock(struct spi_flash *flash, u32 ofs, u32 len)
  *
  * Returns negative on errors, 0 on success.
  */
-int stm_unlock(struct spi_flash *flash, u32 ofs, u32 len)
+int stm_unlock(struct spi_flash *flash, u32 ofs, size_t len)
 {
     uint8_t status_old, status_new;
     u8 mask = SR_BP2 | SR_BP1 | SR_BP0;
-- 

With this change and the other 3 bitops patches I sent I don't see any
more build issues here.

Thanks

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

Fabio,

On 4 November 2015 at 16:38, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Jagan,
>
> On Wed, Nov 4, 2015 at 8:47 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Wed, Nov 4, 2015 at 8:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>> Hi Tom,
>>>
>>> On Wed, Nov 4, 2015 at 1:45 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> On Tue, Nov 3, 2015 at 11:47 PM, Tom Rini <trini@konsulko.com> wrote:
>>>>
>>>>> NAK.
>>>>>
>>>>> So, this blows up badly for a lot of things when I do:
>>>>> ./tools/buildman/buildman -b master --force-build --step 0 -Cdvel
>>>>> 'blackfin|microblaze|m68k|nds32|x86|aarch64|sandbox|mips|avr32|arm|powerpc|sh4|sparc'
>>>>
>>>> It seems I missed to add bitops for avr32 and mips. Will work on it tomorrow.
>>>
>>> I don't see issues after applying the three attached patches.
>>
>> Ops, I do see a build issue in blackfin that didn't happen in previous
>> versions. Will work on fixing it.
>
> When you reworked my series you missed to updated these functions:
>
> diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
> index 31c79c6..d832464 100644
> --- a/drivers/mtd/spi/sf_ops.c
> +++ b/drivers/mtd/spi/sf_ops.c
> @@ -652,7 +652,7 @@ int stm_is_locked(struct spi_flash *flash, u32
> ofs, size_t len)
>   *
>   * Returns negative on errors, 0 on success.
>   */
> -int stm_lock(struct spi_flash *flash, u32 ofs, u32 len)
> +int stm_lock(struct spi_flash *flash, u32 ofs, size_t len)
>  {
>      u8 status_old, status_new;
>      u8 mask = SR_BP2 | SR_BP1 | SR_BP0;
> @@ -703,7 +703,7 @@ int stm_lock(struct spi_flash *flash, u32 ofs, u32 len)
>   *
>   * Returns negative on errors, 0 on success.
>   */
> -int stm_unlock(struct spi_flash *flash, u32 ofs, u32 len)
> +int stm_unlock(struct spi_flash *flash, u32 ofs, size_t len)

Updated u32 to size_t as prototype uses the same. Does this break? it look OK?

thanks!
-- 
Jagan | openedev.

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

Hi Jagan,

On Wed, Nov 4, 2015 at 9:17 AM, Jagan Teki <jteki@openedev.com> wrote:

> Updated u32 to size_t as prototype uses the same. Does this break? it look OK?

Here is the error I see on Blackfin:

Building bf518f-ezbrd board...
/home/fabio/.buildman-toolchains/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux-size:
'./u-boot': No such file
drivers/mtd/spi/sf_ops.c:655:5: error: conflicting types for 'stm_lock'
drivers/mtd/spi/sf_ops.c:706:5: error: conflicting types for 'stm_unlock'
make[1]: *** [drivers/mtd/spi/sf_ops.o] Error 1
make: *** [drivers/mtd/spi] Error 2
drivers/mtd/spi/sf_ops.c:655:5: error: conflicting types for 'stm_lock'
drivers/mtd/spi/sf_internal.h:180:5: note: previous declaration of
'stm_lock' was here
drivers/mtd/spi/sf_ops.c:706:5: error: conflicting types for 'stm_unlock'
drivers/mtd/spi/sf_internal.h:183:5: note: previous declaration of
'stm_unlock' was here
make[1]: *** [drivers/mtd/spi/sf_ops.o] Error 1

By using size_t we fix this conflicting type error.

Regards,

Fabio Estevam

[U-Boot] Pull request: u-boot-spi/next

[Jagan Teki]

On 4 November 2015 at 16:51, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Jagan,
>
> On Wed, Nov 4, 2015 at 9:17 AM, Jagan Teki <jteki@openedev.com> wrote:
>
>> Updated u32 to size_t as prototype uses the same. Does this break? it look OK?
>
> Here is the error I see on Blackfin:
>
> Building bf518f-ezbrd board...
> /home/fabio/.buildman-toolchains/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux-size:
> './u-boot': No such file
> drivers/mtd/spi/sf_ops.c:655:5: error: conflicting types for 'stm_lock'
> drivers/mtd/spi/sf_ops.c:706:5: error: conflicting types for 'stm_unlock'
> make[1]: *** [drivers/mtd/spi/sf_ops.o] Error 1
> make: *** [drivers/mtd/spi] Error 2
> drivers/mtd/spi/sf_ops.c:655:5: error: conflicting types for 'stm_lock'
> drivers/mtd/spi/sf_internal.h:180:5: note: previous declaration of
> 'stm_lock' was here
> drivers/mtd/spi/sf_ops.c:706:5: error: conflicting types for 'stm_unlock'
> drivers/mtd/spi/sf_internal.h:183:5: note: previous declaration of
> 'stm_unlock' was here
> make[1]: *** [drivers/mtd/spi/sf_ops.o] Error 1
>
> By using size_t we fix this conflicting type error.

Yes true, stm_lock and stm_unlock should use size_t for len - Will
update the same.

With these all built fine?

thanks!
-- 
Jagan | openedev.

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

On Wed, Nov 4, 2015 at 9:30 AM, Jagan Teki <jteki@openedev.com> wrote:

> Yes true, stm_lock and stm_unlock should use size_t for len - Will
> update the same.
>
> With these all built fine?

After applying this size_t change plus the three attached bitops
patches I sent you for mips, arc. avr32 I do not see any more build
issues here.

Also, when you apply the three patches to your tree, please make sure
they are applied prior to the "compat: Remove is_power_of_2()
definition" so that we keep bisectability.

Thanks,

Fabio Estevam

[U-Boot] Pull request: u-boot-spi/next

[Fabio Estevam]

On Wed, Nov 4, 2015 at 9:35 AM, Fabio Estevam <festevam@gmail.com> wrote:

> After applying this size_t change plus the three attached bitops
> patches I sent you for mips, arc. avr32 I do not see any more build
> issues here.
>
> Also, when you apply the three patches to your tree, please make sure
> they are applied prior to the "compat: Remove is_power_of_2()
> definition" so that we keep bisectability.

Also, in the v5 I sent I split microblaze and sh changes as you pointed out.

However, you seem to have picked the previous version:
http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commit;h=9918a2c36b10675f9f12e3e3dcfff8f41727b586