public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] arm: socfpga: Remove unused passing parameter of socfpga_bridges_reset
Date: Fri, 12 May 2017 03:46:09 +0000	[thread overview]
Message-ID: <1494560768.6027.13.camel@intel.com> (raw)
In-Reply-To: <9b2faba2-0180-4867-7be0-c16d8f04931d@denx.de>

On Kha, 2017-05-11 at 13:57 +0200, Marek Vasut wrote:
> On 05/11/2017 11:25 AM, tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > Remove unused passing parameter of socfpga_bridges_reset function
> > in
> > SoCFPGA Arria10.
> The commit message is supposed to explain the purpose of the patch,
> but
> there's just no explanation here except for what I can already see in
> the patch itself.
> 
Okay, i will improve it.
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> >  arch/arm/mach-socfpga/include/mach/reset_manager_arria10.h | 2 +-
> >  arch/arm/mach-socfpga/reset_manager_arria10.c              | 4 ++-
> > -
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/mach-
> > socfpga/include/mach/reset_manager_arria10.h b/arch/arm/mach-
> > socfpga/include/mach/reset_manager_arria10.h
> > index 7922db8..b6d7f4f 100644
> > --- a/arch/arm/mach-socfpga/include/mach/reset_manager_arria10.h
> > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager_arria10.h
> > @@ -17,7 +17,7 @@ int socfpga_reset_deassert_bridges_handoff(void);
> >  void socfpga_reset_assert_fpga_connected_peripherals(void);
> >  void socfpga_reset_deassert_osc1wd0(void);
> >  void socfpga_reset_uart(int assert);
> > -int socfpga_bridges_reset(int enable);
> > +int socfpga_bridges_reset(void);
> >  
> >  struct socfpga_reset_manager {
> >  	u32	stat;
> > diff --git a/arch/arm/mach-socfpga/reset_manager_arria10.c
> > b/arch/arm/mach-socfpga/reset_manager_arria10.c
> > index d8c858c..66f1ec2 100644
> > --- a/arch/arm/mach-socfpga/reset_manager_arria10.c
> > +++ b/arch/arm/mach-socfpga/reset_manager_arria10.c
> > @@ -318,13 +318,13 @@ void socfpga_per_reset_all(void)
> >  }
> >  
> >  #if defined(CONFIG_SOCFPGA_VIRTUAL_TARGET)
> > -int socfpga_bridges_reset(int enable)
> > +int socfpga_bridges_reset(void)
> >  {
> >  	/* For SoCFPGA-VT, this is NOP. */
> >  	return 0;
> >  }
> >  #else
> > -int socfpga_bridges_reset(int enable)
> > +int socfpga_bridges_reset(void)
> >  {
> >  	int ret;
> >  
> > 
> 

  reply	other threads:[~2017-05-12  3:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  9:25 [U-Boot] [PATCH v2 0/5] Add Intel Arria 10 SoC FPGA driver tien.fong.chee at intel.com
2017-05-11  9:25 ` [U-Boot] [PATCH v2 1/5] arm: socfpga: Remove unused passing parameter of socfpga_bridges_reset tien.fong.chee at intel.com
2017-05-11 11:57   ` Marek Vasut
2017-05-12  3:46     ` Chee, Tien Fong [this message]
2017-05-11  9:25 ` [U-Boot] [PATCH v2 2/5] arm: socfpga: Restructure FPGA driver in the preparation to support A10 tien.fong.chee at intel.com
2017-05-11 12:03   ` Marek Vasut
2017-05-12  3:45     ` Chee, Tien Fong
2017-05-12  7:26       ` Marek Vasut
2017-05-12  8:10         ` Chee, Tien Fong
2017-05-11  9:25 ` [U-Boot] [PATCH v2 3/5] arm: socfpga: Move FPGA manager driver to FPGA driver tien.fong.chee at intel.com
2017-05-11  9:25 ` [U-Boot] [PATCH v2 4/5] arm: socfpga: Move the FPGA driver header from arch/arm to include/ tien.fong.chee at intel.com
2017-05-11 12:04   ` Marek Vasut
2017-05-12  3:33     ` Chee, Tien Fong
2017-05-12  7:27       ` Marek Vasut
2017-05-12  8:06         ` Chee, Tien Fong
2017-05-11  9:25 ` [U-Boot] [PATCH v2 5/5] arm: socfpga: Add FPGA driver support for Arria 10 tien.fong.chee at intel.com
2017-05-11 12:09   ` Marek Vasut
2017-05-12  3:56     ` Chee, Tien Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494560768.6027.13.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox