From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chee, Tien Fong <tien.fong.chee@intel.com>
Date: Fri, 12 May 2017 08:06:58 +0000
Subject: [U-Boot] [PATCH v2 4/5] arm: socfpga: Move the FPGA driver
 header from arch/arm to include/
In-Reply-To: <1f5cfe5f-76e6-ae09-5f13-22e42b253b9d@denx.de>
References: <1494494734-7888-1-git-send-email-tien.fong.chee@intel.com>
 <1494494734-7888-5-git-send-email-tien.fong.chee@intel.com>
 <3f0c7985-cb2c-4b89-fb81-bae840e20218@denx.de>
 <1494560014.6027.7.camel@intel.com>
 <1f5cfe5f-76e6-ae09-5f13-22e42b253b9d@denx.de>
Message-ID: <1494576418.6027.25.camel@intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Jum, 2017-05-12 at 09:27 +0200, Marek Vasut wrote:
> On 05/12/2017 05:33 AM, Chee, Tien Fong wrote:
> > 
> > On Kha, 2017-05-11 at 14:04 +0200, Marek Vasut wrote:
> > > 
> > > On 05/11/2017 11:25 AM, tien.fong.chee at intel.com wrote:
> > > > 
> > > > 
> > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > 
> > > > Move arch/arm FPGA driver header to include/intel_socfpga which
> > > > would be shared between arch platform drivers and FPGA drivers.
> > > Doesn't this patchset only add support for arria10 FPGA ? If so,
> > > this
> > > patch is pointless in the context of this patchset.
> > > 
> > Arria10 FPGA header include fpga_manager.h as common header.There
> > are
> > other headers depend on above common header. So that means they are
> > all
> > related to each others. Hence this patch is needed to ensure all
> > related restructure properly before adding Arria10 FPGA driver.
> But that stuff can still be in arch/arm/mach-socfpga/include , why do
> you move stuff into include/intel_fpg
> 
Ohh...i already moved the fpga manager driver into driver/fpga, hence i
think the header file supposely should be moved into include/ because
it would be refered by both /drivers and arch/arm/mach-socfpga/. I
checked someothers also have this kind implementation. I am not sure
the U-boot framework is designed in this way, i can revert the changes
if it is not.
> > 
> > > 
> > > > 
> > > > 
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > ---
> > > >  arch/arm/mach-socfpga/reset_manager_arria10.c |  2 +-
> > > >  arch/arm/mach-socfpga/reset_manager_gen5.c    |  5 +-
> > > >  arch/arm/mach-socfpga/system_manager_gen5.c   |  2 +-
> > > >  drivers/ddr/altera/sdram.c                    |  5 +-
> > > >  drivers/fpga/socfpga.c                        |  5 +-
> > > >  drivers/fpga/socfpga_gen5.c                   |  2 +-
> > > >  include/intel_socfpga/fpga_manager.h          | 37
> > > > +++++++++++++++
> > > >  include/intel_socfpga/fpga_manager_gen5.h     | 68
> > > > +++++++++++++++++++++++++++
> > > >  8 files changed, 116 insertions(+), 10 deletions(-)
> > > >  create mode 100644 include/intel_socfpga/fpga_manager.h
> > > >  create mode 100644 include/intel_socfpga/fpga_manager_gen5.h
> [...]
>