U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 6/9] crypto: fsl: Allocate memory for descriptor from main memory
Date: Mon, 15 May 2017 09:16:06 -0700	[thread overview]
Message-ID: <1494864969-7374-7-git-send-email-york.sun@nxp.com> (raw)
In-Reply-To: <1494864969-7374-1-git-send-email-york.sun@nxp.com>

When U-Boot runs at EL2 on ARMv8, OCRAM is in secure world on some
SoCs by default. Allocation of memory from OCRAM causes failure in
this case. Since main memory is available, allocating memory
from heap is successful.

Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
Signed-off-by: York Sun <york.sun@nxp.com>
---

 drivers/crypto/fsl/fsl_rsa.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/fsl/fsl_rsa.c b/drivers/crypto/fsl/fsl_rsa.c
index 32c059f..5192267 100644
--- a/drivers/crypto/fsl/fsl_rsa.c
+++ b/drivers/crypto/fsl/fsl_rsa.c
@@ -48,8 +48,14 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
 {
 	uint32_t keylen;
 	struct pk_in_params pkin;
-	uint32_t desc[MAX_CAAM_DESCSIZE];
-	int ret;
+	uint32_t *desc;
+	int ret = 0;
+
+	desc = malloc(MAX_CAAM_DESCSIZE);
+	if (!desc) {
+		printf("RSA DESC: malloc failed for RSA descriptor\n");
+		return -ENOMEM;
+	}
 
 	/* Length in bytes */
 	keylen = prop->num_bits / 8;
@@ -66,10 +72,11 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
 	ret = run_descriptor_jr(desc);
 	if (ret) {
 		debug("%s: RSA failed to verify: %d\n", __func__, ret);
-		return -EFAULT;
+		ret = -EFAULT;
 	}
+	free(desc);
 
-	return 0;
+	return ret;
 }
 
 static const struct mod_exp_ops fsl_mod_exp_ops = {
-- 
2.7.4

  parent reply	other threads:[~2017-05-15 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 16:16 [U-Boot] [PATCH v1 0/9] Enable falcon boot for LS1043ARDB SDCARD boot York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 1/9] armv8: ls1043ardb: Use static DDR setting for SPL secure boot York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 2/9] armv8: layerscape: Eanble falcon boot York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 3/9] armv8: ls1043ardb_sdcard: Enable " York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 4/9] fsl: secure boot: Remove dependency of command line for fsl_validate.c York Sun
2017-11-29 18:39   ` York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 5/9] fsl: secure boot: Add fsl_rsa_modexp_raw function for scenarios without DM model York Sun
2017-05-15 16:16 ` York Sun [this message]
2017-05-15 16:16 ` [U-Boot] [PATCH v1 7/9] armv8: fsl-layerscape: Enable secure boot valiation for SPL boot York Sun
2017-05-16  0:37   ` Tom Rini
2017-05-16 16:04     ` york sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 8/9] armv8: layerscape: falcon: Implement FIT image validation York Sun
2017-05-15 16:16 ` [U-Boot] [PATCH v1 9/9] armv8: ls1043ardb: Enable loading PPA and falcon boot for SD secure boot York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494864969-7374-7-git-send-email-york.sun@nxp.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox