From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 5/16] cmd: Add Kconfig option for CMD_MTDPARTS and related options
Date: Thu, 01 Jun 2017 07:57:04 +0200 [thread overview]
Message-ID: <1496296624.8561.0.camel@embedded.rocks> (raw)
In-Reply-To: <20170531194747.nph3p2fkzzk4pth5@flea.lan>
Hi Maxime,
On Wed, 2017-05-31 at 21:47 +0200, Maxime Ripard wrote:
> On Wed, May 31, 2017 at 08:27:33AM +0200, Jörg Krause wrote:
> > Hi Maxime,
> >
> > On Tue, 2017-05-30 at 23:09 +0200, Maxime Ripard wrote:
> > > Hi Jörg,
> > >
> > > On Tue, May 30, 2017 at 09:39:57AM +0200, Jörg Krause wrote:
> > > > On Mon, 2017-02-27 at 18:22 +0100, Maxime Ripard wrote:
> > > > > CMD_MTDPARTS is something the user might or might not want to
> > > > > select,
> > > > > and
> > > > > might depends on (or be selected by) other options too.
> > > > >
> > > > > This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT
> > > > > options that
> > > > > might change from one board to another, or from one user to the
> > > > > other,
> > > > > depending on what it expects and what storage devices are
> > > > > available.
> > > > >
> > > > > In order to ease that configuration, add those options to
> > > > > Kconfig.
> > > > >
> > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > > > Reviewed-by: Tom Rini <trini@konsulko.com>
> > > > > ---
> > > > > cmd/Kconfig | 20 ++++++++++++++++++++
> > > > > cmd/mtdparts.c | 8 ++++++++
> > > > > 2 files changed, 28 insertions(+), 0 deletions(-)
> > > > >
> > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > > > > index ef5315631476..0734d669dbd7 100644
> > > > > --- a/cmd/Kconfig
> > > > > +++ b/cmd/Kconfig
> > > > > @@ -801,6 +801,26 @@ config CMD_FS_GENERIC
> > > > > help
> > > > > Enables filesystem commands (e.g. load, ls) that work
> > > > > for
> > > > > multiple
> > > > > fs types.
> > > > > +
> > > > > +config CMD_MTDPARTS
> > > > > + depends on ARCH_SUNXI
> > > >
> > > > Is there any reason to limit the command for the sunxi arch only?
> > >
> > > Yes, if we don't, this will generate warnings for each architecture
> > > that has not moved that option from their header to Kconfig.
> >
> > I see! However, wouldn't it be best to migrate all architectures to
> > Kconfig instead of doing it seperately?
>
> Probably, but there was a quite significant number of Kconfig symbols
> introduced, used by a very significant number of boards and
> architectures.
I see!
> This was really to unreasonable to do at the time, but we can
> definitely do that now.
That would be great! Many thanks!
Jörg
next prev parent reply other threads:[~2017-06-01 5:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 17:21 [U-Boot] [PATCH v5 0/16] sunxi: Add support for the CHIP Pro Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 1/16] nand: sunxi: Fix modulo by zero error Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 2/16] bch: Allow to build for the host Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 3/16] tools: sunxi: Add spl image builder Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 4/16] common: Move environment choice to Kconfig Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 5/16] cmd: Add Kconfig option for CMD_MTDPARTS and related options Maxime Ripard
2017-05-30 7:39 ` Jörg Krause
2017-05-30 21:09 ` Maxime Ripard
2017-05-31 6:27 ` Jörg Krause
2017-05-31 19:47 ` Maxime Ripard
2017-06-01 5:53 ` Jörg Krause
2017-06-01 5:57 ` Jörg Krause [this message]
2017-02-27 17:22 ` [U-Boot] [PATCH v5 6/16] mtd: ubi: Select RBTREE option from MTD_UBI Kconfig entry Maxime Ripard
2017-02-27 17:49 ` Boris Brezillon
2017-02-27 17:22 ` [U-Boot] [PATCH v5 7/16] cmd: Expose a Kconfig option to enable UBIFS commands Maxime Ripard
2017-05-30 7:42 ` Jörg Krause
2017-02-27 17:22 ` [U-Boot] [PATCH v5 8/16] cmd: nand: Expose optional suboptions in Kconfig Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 9/16] mtd: sunxi: Select the U-Boot location config option Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 10/16] mtd: sunxi: Change U-Boot offset Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 11/16] sunxi: Enable UBI and NAND support Maxime Ripard
2017-03-02 8:32 ` Chen-Yu Tsai
2017-02-27 17:22 ` [U-Boot] [PATCH v5 12/16] sunxi: Add the default mtdids and mtdparts to our env Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 13/16] nand: sunxi: Add options for the SPL NAND configuration Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 14/16] scripts: sunxi: Build an raw SPL image Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 15/16] sunxi: Sync GR8 DTS and AXP209 with the kernel Maxime Ripard
2017-02-27 17:22 ` [U-Boot] [PATCH v5 16/16] sunxi: Add support for the CHIP Pro Maxime Ripard
2017-03-01 15:58 ` Tom Rini
2017-03-03 14:48 ` Maxime Ripard
2017-03-03 15:00 ` Tom Rini
2017-02-28 14:19 ` [U-Boot] [PATCH v5 0/16] " Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496296624.8561.0.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox