From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Mon, 5 Jun 2017 04:02:05 +0000 Subject: [U-Boot] [PATCH v7 3/6] arm: socfpga: Enable FPGA driver on SPL In-Reply-To: <1496633548.2428.5.camel@intel.com> References: <1496030410-8263-1-git-send-email-tien.fong.chee@intel.com> <1496030410-8263-4-git-send-email-tien.fong.chee@intel.com> <1496633548.2428.5.camel@intel.com> Message-ID: <1496635319.2428.14.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Isn, 2017-06-05 at 11:32 +0800, Chee, Tien Fong wrote: > > > > > > On Sab, 2017-06-03 at 13:27 +0200, Marek Vasut wrote: > > > > On 05/29/2017 06:00 AM, tien.fong.chee at intel.com wrote: > > > > > > > > > From: Tien Fong Chee > > > > > > This patch is for enabling the FPGA driver support on SPL. > > > > > > Signed-off-by: Tien Fong Chee > > > --- > > >  include/configs/socfpga_common.h | 1 + > > >  1 file changed, 1 insertion(+) > > > > > > diff --git a/include/configs/socfpga_common.h > > > b/include/configs/socfpga_common.h > > > index da7e4ad..e74e7eb 100644 > > > --- a/include/configs/socfpga_common.h > > > +++ b/include/configs/socfpga_common.h > > > @@ -110,6 +110,7 @@ > > >  #define CONFIG_FPGA > > >  #define CONFIG_FPGA_ALTERA > > >  #define CONFIG_FPGA_SOCFPGA > > > +#define CONFIG_SPL_FPGA_SUPPORT > > This should be Kconfig symbol selected in board config. Why is it > > not > > Kconfig symbol ? > > Ahha....ijust recalled there is a very important reason i did this because CONFIG_CMD_FPGA which is wrapping all these FPGA related CONFIG is not part of kconfig. During the build, kconfig and Macro #define are in two different phase/order, so we might having build issue during kconfig build(1st phase) when some Macro #define which is 2nd phase are required. > I have a patch that is specific for converting all FPGA related Macro > config by tool created which will be submited after this patch set. > Let me know if you prefer kconfig symbol. > > > > > >  #define CONFIG_FPGA_COUNT 1 > > >  #endif > > >  #endif > > >