[U-Boot] [PATCH v8 5/7] drivers: Enable FPGA driver build on SPL

Chee, Tien Fong
2017-06-06T08:26:43Z

On Sel, 2017-06-06 at 10:03 +0200, Marek Vasut wrote:
> On 06/06/2017 08:35 AM, tien.fong.chee at intel.com wrote:
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Enable FPGA driver build for SPL because FPGA driver is needed for
> > SPL
> > to configure and getting DDR up before loading U-boot into DDR and
> > booting from there.
> >
> > FPGA driver build on SPL must be enabled 1st before applying next
> > patch to
> > avoid build failed, because fpga_manager which would be moved to
> > drivers/fpga by next patch are required in SPL.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> You should probably swap this and 4/5 ?
>
I have no strong opinion about this swapping. Don't you think that it's
much more sensible having enabling FPGA support on SPL(configuration
1st), then only enable the build?
> >
> > ---
> >  drivers/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 64c39d3..4478212 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -48,6 +48,7 @@ obj-$(CONFIG_OMAP_USB_PHY) += usb/phy/
> >  obj-$(CONFIG_SPL_SATA_SUPPORT) += block/
> >  obj-$(CONFIG_SPL_USB_HOST_SUPPORT) += block/
> >  obj-$(CONFIG_SPL_MMC_SUPPORT) += block/
> > +obj-$(CONFIG_SPL_FPGA_SUPPORT) += fpga/
> >  endif
> >
> >  ifdef CONFIG_TPL_BUILD
> >
>