[U-Boot] [PATCH] arc: Move dram_init out of arch code, into board code

Alexey Brodkin
2017-06-15T19:21:07Z

Hi Alexandru,

On Mon, 2017-06-05 at 13:00 -0700, Alexandru Gagniuc wrote:
> On 06/05/2017 12:22 PM, Alexey Brodkin wrote:
> >
> > Hi Alexandru,
> >
> > On Mon, 2017-06-05 at 10:49 -0700, Alexandru Gagniuc wrote:
> > >
> > > The following commit
> > > f1683aa board_f: Rename initdram() to dram_init()
> > > wrongly assumed that the lack of DRAM init is the property of the
> > > architecture. In fact, it is only the AXS10x boards that do not need a
> > > special raminit. Those assumptions are not true on the ARC SoC we're
> > > looking at.
> >
> > Actually there're more boards with ARC cores.
> > In particular nSIM for ARC700  and ARC HS38, as well as Abilis TB100.
>
> Oops. Missed those. I'll have an updated patch later in the week.
>
>
> >
> > So it might make sense to declare generic dram_init() in arch/arc/lib/cpu.c
> > as a weak function and add your own implementations as needed.
>
> I disagree. The few saved lines of code to properly link the correct
> function are not worth the lost days when figuring out why my xyz()
> function is not doing the right thing.
>
>
> >
> > BTW since commit 80e4bbfcd92d "travisci: Add support for ARC"
>
> I'll give that a try, thanks!

Any progress with that one?
Or I'm missing your respin(s)?

-Alexey