public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier
Date: Tue, 04 Jul 2017 22:48:36 +0300	[thread overview]
Message-ID: <1499197716.22624.262.camel@linux.intel.com> (raw)
In-Reply-To: <20170418164926.040301f7@jawa>

On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> 
> The code seems OK, but recently patches to add wdt-uclass has been
> posted:
> 
> http://patchwork.ozlabs.org/patch/751448/
> http://patchwork.ozlabs.org/patch/751451/
> 
> Maybe it would be better to port this driver to the uclass from the
> very beginning?

I started looking into this direction and have a question:
what the point to move to that class if it's broken from the beginning?

I really do not understand who on the earth would like to have
wdt_stop() at ->probe() (the only two users do exactly that!).

So, it looks to me now as bikeshedding, otherwise where is the
documentation which describes how this all stuff should work?

Can we go with the initial patch?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  parent reply	other threads:[~2017-07-04 19:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 13:51 [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier Andy Shevchenko
2017-04-18 14:49 ` Lukasz Majewski
2017-04-18 14:57   ` Andy Shevchenko
2017-04-18 16:30     ` Tom Rini
2017-07-04 19:48   ` Andy Shevchenko [this message]
2017-07-04 20:31     ` Tom Rini
2017-07-04 20:41       ` Andy Shevchenko
2017-07-04 21:23         ` lukma
2017-07-04 22:36           ` Andy Shevchenko
2017-07-05 15:59       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499197716.22624.262.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox