From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Tue, 04 Jul 2017 22:48:36 +0300 Subject: [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier In-Reply-To: <20170418164926.040301f7@jawa> References: <20170418135149.39798-1-andriy.shevchenko@linux.intel.com> <20170418164926.040301f7@jawa> Message-ID: <1499197716.22624.262.camel@linux.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote: > > The code seems OK, but recently patches to add wdt-uclass has been > posted: > > http://patchwork.ozlabs.org/patch/751448/ > http://patchwork.ozlabs.org/patch/751451/ > > Maybe it would be better to port this driver to the uclass from the > very beginning? I started looking into this direction and have a question: what the point to move to that class if it's broken from the beginning? I really do not understand who on the earth would like to have wdt_stop() at ->probe() (the only two users do exactly that!). So, it looks to me now as bikeshedding, otherwise where is the documentation which describes how this all stuff should work? Can we go with the initial patch? -- Andy Shevchenko Intel Finland Oy