From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier
Date: Wed, 05 Jul 2017 18:59:14 +0300 [thread overview]
Message-ID: <1499270354.22624.267.camel@linux.intel.com> (raw)
In-Reply-To: <20170704203116.GN9889@bill-the-cat>
On Tue, 2017-07-04 at 16:31 -0400, Tom Rini wrote:
> On Tue, Jul 04, 2017 at 10:48:36PM +0300, Andy Shevchenko wrote:
> > On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> > So, it looks to me now as bikeshedding, otherwise where is the
> > documentation which describes how this all stuff should work?
> >
> > Can we go with the initial patch?
>
> If it looks like some nightmare to fix the DM uclass, I suppose, but,
> is
> it really that bad off atm?
So, I have looked more, I even start creating patches and it's a deep
hole. It looks like that class has nothing to do with the main purpose
of watchdog. There is no integration into U-Boot watchdog infrastructure
(to actually use it).
I'm about to test what I have, I need to correct a bit still, and will
send a v3 using old approach. I will send patches against WDT class as
RFC, but I'm not going to support them. My opinion is steady now -- that
class is unusable in the current state.
P.S. If I'm missing something obvious I would like to hear it ASAP to
make my driver use that class.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-07-05 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 13:51 [U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier Andy Shevchenko
2017-04-18 14:49 ` Lukasz Majewski
2017-04-18 14:57 ` Andy Shevchenko
2017-04-18 16:30 ` Tom Rini
2017-07-04 19:48 ` Andy Shevchenko
2017-07-04 20:31 ` Tom Rini
2017-07-04 20:41 ` Andy Shevchenko
2017-07-04 21:23 ` lukma
2017-07-04 22:36 ` Andy Shevchenko
2017-07-05 15:59 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499270354.22624.267.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox