From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 05 Jul 2017 22:58:58 +0300
Subject: [U-Boot] [U-Boot,RFC,v1] wdt: Add a glue driver for watchdog
In-Reply-To: <4185bd15-d25a-a904-00ab-ac6f649c0469@gmx.de>
References: <20170705174543.72997-1-andriy.shevchenko@linux.intel.com>
 <4185bd15-d25a-a904-00ab-ac6f649c0469@gmx.de>
Message-ID: <1499284738.22624.281.camel@linux.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2017-07-05 at 21:56 +0200, Heinrich Schuchardt wrote:
> On 07/05/2017 07:45 PM, Andy Shevchenko wrote:

> > This is not a working solution, just an opinion to which direction
> > we might go
> > with ugly broken WDT class.
> > 
> > Feel free to ignore, drop, modify, etc.

^^^^^^ DISCLAIMER

> > +	ret = wdt_reset(wdt);
> > +	if (ret)
> > +		printf("Can't reset watchdog device: %d\n", ret);
> 
> I would suggest debug() instead of printf().
> 
> Imagine this being called from an EFI application in a loop. We
> wouldn't
> want to fill the screen with this message.

Thanks for the indeed correct suggestion, though please read a
disclaimer above. I gave up on that.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy