From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Thu, 13 Jul 2017 08:08:48 +0000 Subject: [U-Boot] [PATCH v11 3/6] kconfig: Convert FPGA and FPGA_ALTERA configuration to Kconfig In-Reply-To: <7d38abd6-308e-1245-373f-ef7aa669649d@denx.de> References: <1499072829-5626-1-git-send-email-tien.fong.chee@intel.com> <1499072829-5626-5-git-send-email-tien.fong.chee@intel.com> <1499910416.4335.3.camel@intel.com> <7d38abd6-308e-1245-373f-ef7aa669649d@denx.de> Message-ID: <1499933327.4335.11.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Kha, 2017-07-13 at 08:31 +0200, Marek Vasut wrote: > On 07/13/2017 03:46 AM, Chee, Tien Fong wrote: > > > > On Rab, 2017-07-12 at 12:56 +0200, Marek Vasut wrote: > > > > > > On 07/03/2017 11:07 AM, tien.fong.chee at intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee > > > > > > > > This converts the following to Kconfig: > > > >    CONFIG_FPGA > > > >    CONFIG_FPGA_ALTERA > > > > > > > > Signed-off-by: Tien Fong Chee > > > > Reviewed-by: Ley Foon Tan > > > > Reviewed-by: Dinh Nguyen > > > Did you run make savedefconfig on all these boards or did you > > > just > > > put > > > the CONFIG_FPGA_ALTERA=y into their defconfigs ? > > > > > I'm not only run make defconfig. I also running compilation on all > > effeted defconfigs. > That doesn't answer my question. Did you do something like > make savedefconfig > cp defconfig configs/foo_defconfig > ? > Sorry for confusing, i don't know make savedefconfig is for creating new defconfig based on .config until i googled it. CONFIG_FPGA_ALTERA=y was put into their defconfigs after running moveconfig script. > > > > > > > > > > > > > > > > > --- > > > >  configs/astro_mcf5373l_defconfig    | 1 + > > > >  configs/theadorable_debug_defconfig | 1 + > > > >  configs/theadorable_defconfig       | 1 + > > > >  include/configs/astro_mcf5373l.h    | 2 -- > > > >  include/configs/theadorable.h       | 2 -- > > > >  5 files changed, 3 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/configs/astro_mcf5373l_defconfig > > > > b/configs/astro_mcf5373l_defconfig > > > > index d5e8430..80fb1fa 100644 > > > > --- a/configs/astro_mcf5373l_defconfig > > > > +++ b/configs/astro_mcf5373l_defconfig > > > > @@ -10,4 +10,5 @@ CONFIG_CMD_I2C=y > > > >  # CONFIG_CMD_NFS is not set > > > >  CONFIG_CMD_CACHE=y > > > >  CONFIG_CMD_DATE=y > > > > +CONFIG_FPGA_ALTERA=y > > > >  CONFIG_MTD_NOR_FLASH=y > > > > diff --git a/configs/theadorable_debug_defconfig > > > > b/configs/theadorable_debug_defconfig > > > > index 2164237..e07b7b6 100644 > > > > --- a/configs/theadorable_debug_defconfig > > > > +++ b/configs/theadorable_debug_defconfig > > > > @@ -43,6 +43,7 @@ CONFIG_EFI_PARTITION=y > > > >  # CONFIG_SPL_PARTITION_UUIDS is not set > > > >  CONFIG_NET_RANDOM_ETHADDR=y > > > >  CONFIG_SPL_OF_TRANSLATE=y > > > > +CONFIG_FPGA_ALTERA=y > > > >  CONFIG_DM_GPIO=y > > > >  # CONFIG_MMC is not set > > > >  CONFIG_SPI_FLASH=y > > > > diff --git a/configs/theadorable_defconfig > > > > b/configs/theadorable_defconfig > > > > index d5eef70..3d2977c 100644 > > > > --- a/configs/theadorable_defconfig > > > > +++ b/configs/theadorable_defconfig > > > > @@ -37,6 +37,7 @@ CONFIG_EFI_PARTITION=y > > > >  # CONFIG_PARTITION_UUIDS is not set > > > >  # CONFIG_SPL_PARTITION_UUIDS is not set > > > >  CONFIG_SPL_OF_TRANSLATE=y > > > > +CONFIG_FPGA_ALTERA=y > > > >  CONFIG_DM_GPIO=y > > > >  # CONFIG_MMC is not set > > > >  CONFIG_SPI_FLASH=y > > > > diff --git a/include/configs/astro_mcf5373l.h > > > > b/include/configs/astro_mcf5373l.h > > > > index 8899579..f4acea1 100644 > > > > --- a/include/configs/astro_mcf5373l.h > > > > +++ b/include/configs/astro_mcf5373l.h > > > > @@ -201,10 +201,8 @@ > > > >  #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE > > > >   > > > >  #define CONFIG_FPGA_COUNT 1 > > > > -#define CONFIG_FPGA > > > >  #define CONFIG_FPGA_XILINX > > > >  #define CONFIG_FPGA_SPARTAN3 > > > > -#define CONFIG_FPGA_ALTERA > > > >  #define CONFIG_FPGA_CYCLON2 > > > >  #define CONFIG_SYS_FPGA_PROG_FEEDBACK > > > >  #define CONFIG_SYS_FPGA_WAIT 1000 > > > > diff --git a/include/configs/theadorable.h > > > > b/include/configs/theadorable.h > > > > index 2a671e8..5459f4f 100644 > > > > --- a/include/configs/theadorable.h > > > > +++ b/include/configs/theadorable.h > > > > @@ -89,8 +89,6 @@ > > > >  #define CONFIG_SYS_MEM_TOP_HIDE 0x80000 > > > >   > > > >  /* FPGA programming support */ > > > > -#define CONFIG_FPGA > > > > -#define CONFIG_FPGA_ALTERA > > > >  #define CONFIG_FPGA_STRATIX_V > > > >   > > > >  /* > > > > >