public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] arm: socfpga: Enable FPGA bridge in gen5 U-boot
Date: Thu, 27 Jul 2017 09:26:22 +0000	[thread overview]
Message-ID: <1501147582.3184.13.camel@intel.com> (raw)
In-Reply-To: <af29f2bc-a071-cb25-b568-8bb62efe403b@denx.de>

On Kha, 2017-07-27 at 10:24 +0200, Marek Vasut wrote:
> On 07/27/2017 06:36 AM, tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > Enable FPGA bridge in gen5 U-boot instead of gen5 SPL because FPGA
> > feature is not
> > required in SPL. Remove FPGA feature in SPL can help to save some
> > space.
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> >  include/configs/socfpga_common.h |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h
> > index 9be9e79..f5b3277 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -70,6 +70,10 @@
> >  #define CONFIG_CMD_PXE
> >  #define CONFIG_MENU
> >  
> > +#if defined(CONFIG_TARGET_SOCFPGA_GEN5)
> > +#define CONFIG_PREBOOT "bridge enable; echo bridge enable"
> > +#endif
> If someone needs to define their own preboot env, this will break.
> If the FPGA is not programmed, this will also break.
> 
I think we can add one new config for FPGA is programmed or not.
However, i think this should be as default since most intel fpga
devkits have this feature, but user can edit the environment in code,
or in boot console. I prefer not to hard code this in the code like
what previously doing in gen5. DO you have any better idea?
> > 
> >  /*
> >   * Cache
> >   */
> > 
> 

  reply	other threads:[~2017-07-27  9:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  4:36 [U-Boot] [PATCH 0/3] Remove unused FPGA feature from gen5 SPL tien.fong.chee at intel.com
2017-07-27  4:36 ` [U-Boot] [PATCH 1/3] arm: socfpga: " tien.fong.chee at intel.com
2017-07-27  8:21   ` Marek Vasut
2017-07-27  9:21     ` Chee, Tien Fong
2017-07-27  9:37       ` Marek Vasut
2017-07-28  5:16         ` Chee, Tien Fong
2017-07-28  7:52           ` Marek Vasut
2017-07-28 11:35             ` Chee, Tien Fong
2017-07-28 11:40               ` Marek Vasut
2017-07-31 10:03                 ` Chee, Tien Fong
2017-07-27  4:36 ` [U-Boot] [PATCH 2/3] arm: socfpga: Move Gen5 FPGA manager driver to FPGA driver tien.fong.chee at intel.com
2017-07-27  4:36 ` [U-Boot] [PATCH 3/3] arm: socfpga: Enable FPGA bridge in gen5 U-boot tien.fong.chee at intel.com
2017-07-27  8:24   ` Marek Vasut
2017-07-27  9:26     ` Chee, Tien Fong [this message]
2017-07-27  9:39       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501147582.3184.13.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox