From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Thu, 27 Jul 2017 09:26:22 +0000 Subject: [U-Boot] [PATCH 3/3] arm: socfpga: Enable FPGA bridge in gen5 U-boot In-Reply-To: References: <1501130208-2278-1-git-send-email-tien.fong.chee@intel.com> <1501130208-2278-4-git-send-email-tien.fong.chee@intel.com> Message-ID: <1501147582.3184.13.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Kha, 2017-07-27 at 10:24 +0200, Marek Vasut wrote: > On 07/27/2017 06:36 AM, tien.fong.chee at intel.com wrote: > > > > From: Tien Fong Chee > > > > Enable FPGA bridge in gen5 U-boot instead of gen5 SPL because FPGA > > feature is not > > required in SPL. Remove FPGA feature in SPL can help to save some > > space. > > > > Signed-off-by: Tien Fong Chee > > --- > >  include/configs/socfpga_common.h |    4 ++++ > >  1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/include/configs/socfpga_common.h > > b/include/configs/socfpga_common.h > > index 9be9e79..f5b3277 100644 > > --- a/include/configs/socfpga_common.h > > +++ b/include/configs/socfpga_common.h > > @@ -70,6 +70,10 @@ > >  #define CONFIG_CMD_PXE > >  #define CONFIG_MENU > >   > > +#if defined(CONFIG_TARGET_SOCFPGA_GEN5) > > +#define CONFIG_PREBOOT "bridge enable; echo bridge enable" > > +#endif > If someone needs to define their own preboot env, this will break. > If the FPGA is not programmed, this will also break. > I think we can add one new config for FPGA is programmed or not. However, i think this should be as default since most intel fpga devkits have this feature, but user can edit the environment in code, or in boot console. I prefer not to hard code this in the code like what previously doing in gen5. DO you have any better idea? > > > >  /* > >   * Cache > >   */ > > >