From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/6] pci: tegra: introduce weak tegra_pcie_board_port_reset() function
Date: Wed, 9 Aug 2017 20:20:27 +0000 [thread overview]
Message-ID: <1502310025.27304.19.camel@toradex.com> (raw)
In-Reply-To: <cbfce160-8302-337d-4a86-54fc9f8a0867@wwwdotorg.org>
On Wed, 2017-08-09 at 12:47 -0600, Stephen Warren wrote:
> On 08/09/2017 09:31 AM, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Introduce a weak tegra_pcie_board_port_reset() function by default
> > calling the existing tegra_pcie_port_reset() function. Additionally
> > add
> > a tegra_pcie_port_index_of_port() function to retrieve the specific
> > PCIe
> > port index if required. This allows overriding the PCIe port reset
> > functionality from board specific code as e.g. required for Apalis
> > T30
> > and Apalis TK1.
> > diff --git a/drivers/pci/pci_tegra.c b/drivers/pci/pci_tegra.c
> > -static void tegra_pcie_port_reset(struct tegra_pcie_port *port)
> > +void tegra_pcie_port_reset(struct tegra_pcie_port *port)
> > {
> > unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port);
> > unsigned long value;
> >
> > /* pulse reset signel */
> > - value = afi_readl(port->pcie, ctrl);
> > + value = afi_readl(((struct tegra_pcie_port *)port)->pcie,
> > ctrl);
>
> You don't need to add these casts any more.
Argh, yeah you are right. I could have sworn I double/triple checked it all. Just sent out a v4 with this now.
next prev parent reply other threads:[~2017-08-09 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 15:31 [U-Boot] [PATCH v3 0/6] fix apalis-tk1 pcie gigabit ethernet operation Marcel Ziswiler
2017-08-09 15:31 ` [U-Boot] [PATCH v3 1/6] configs: apalis-tk1: fix boot failure using ext4 rootfs Marcel Ziswiler
2017-08-09 15:31 ` [U-Boot] [PATCH v3 2/6] apalis-tk1: add missing as3722 gpio0 configuration Marcel Ziswiler
2017-08-09 15:31 ` [U-Boot] [PATCH v3 3/6] power: as3722: fix ldo_get/set_enable for ldo index bigger than 7 Marcel Ziswiler
2017-08-09 15:31 ` [U-Boot] [PATCH v3 4/6] pci: tegra: introduce weak tegra_pcie_board_port_reset() function Marcel Ziswiler
2017-08-09 18:47 ` Stephen Warren
2017-08-09 20:20 ` Marcel Ziswiler [this message]
2017-08-09 15:31 ` [U-Boot] [PATCH v3 5/6] power: as3722: add as3722_ldo_set_voltage signature to header file Marcel Ziswiler
2017-08-09 15:31 ` [U-Boot] [PATCH v3 6/6] apalis-tk1: fix pcie reset for reliable gigabit ethernet operation Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502310025.27304.19.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox