From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FSL PCIe LTSSM >= PCI_LTSSM_L0 equals link up
Date: Mon, 28 Aug 2017 17:09:03 +0000 [thread overview]
Message-ID: <1503940141.4350.36.camel@infinera.com> (raw)
In-Reply-To: <VI1PR04MB2078693229053F59A24226F09A9E0@VI1PR04MB2078.eurprd04.prod.outlook.com>
On Mon, 2017-08-28 at 16:55 +0000, York Sun wrote:
> On 08/28/2017 09:48 AM, Joakim Tjernlund wrote:
> > FSL PCIe controller drivers before REV 3 has this test for link up:
> > enabled = ltssm >= PCI_LTSSM_L0;
> >
> > We have a PCIe dev. that stays in LTSSM=0x51 (Polling Compliance) when non ready
> > for PCI transaktions. When FSL PCIe controller tries to access this device, it
> > hangs forever.
> >
> > Is LTSSM=0x51 really a "legal" state for link up?
> > If not, what is a suitable range(maybe LO <= ltssm <= L0s(0x27)) ?
> >
> > Jocke
> >
> > BTW, the same test is valid in Linux too.
> >
>
> Jocke,
>
> I am not an expert on PCIe. Please if this thread is helpful,
Me neither .. :)
>
> http://patchwork.ozlabs.org/patch/801519/.
It mentions polling compliance but this driver already tests for:
if (ltssm < LTSSM_PCIE_L0)
return 0;
return 1;
It just adds some delay if the device is in Polling Compliance to see if that
changes to L0.
Since both layerscape and fsl >= rev 3 already require ltssm to be == L0, I suspect
the ltssm >= L0 is bogus.
Jocke
next prev parent reply other threads:[~2017-08-28 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 16:48 [U-Boot] FSL PCIe LTSSM >= PCI_LTSSM_L0 equals link up Joakim Tjernlund
2017-08-28 16:55 ` York Sun
2017-08-28 17:09 ` Joakim Tjernlund [this message]
2017-08-28 17:14 ` York Sun
2017-08-29 3:19 ` Xiaowei Bao
2017-08-29 6:45 ` Joakim Tjernlund
2017-08-29 9:53 ` Xiaowei Bao
2017-08-29 10:26 ` Joakim Tjernlund
2017-08-29 10:46 ` Xiaowei Bao
2017-08-29 10:49 ` Joakim Tjernlund
2017-08-29 11:01 ` Xiaowei Bao
2017-09-05 11:08 ` Joakim Tjernlund
2017-09-06 15:36 ` York Sun
2017-09-07 8:12 ` Mingkai Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503940141.4350.36.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox