[U-Boot] [linux-sunxi] Re: [PATCH 3/4] sunxi: dts: added emac node for nanopi m1

Chen-Yu Tsai
2017-08-31T01:31:20Z

On Thu, Aug 31, 2017 at 7:10 AM, Philipp Rossak <embed3d@gmail.com> wrote:
>
>
> On 30.08.2017 18:59, Jagan Teki wrote:
>>
>> On Wed, Aug 30, 2017 at 8:06 PM, Ondřej Jirman <megi@xff.cz> wrote:
>>>
>>> Hi,
>>>
>>> Jagan Teki píše v St 30. 08. 2017 v 19:48 +0530:
>>>>
>>>> On Wed, Aug 30, 2017 at 2:40 PM, Philipp Rossak <embed3d@gmail.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> Am 30.08.2017 um 08:47 schrieb Jagan Teki:
>>>>>>
>>>>>> On Wed, Aug 30, 2017 at 6:02 AM, Philipp Rossak <embed3d@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> From: Philipp Rossak <embed3d@gmail.com>
>>>>>>>
>>>>>>> The sun8i emac hardware is present on the Nanopi M1.
>>>>>>> It uses the internal PHY.
>>>>>>>
>>>>>>> Signed-off-by: Philipp Rossak <embed3d@gmail.com>
>>>>>>> ---
>>>>>>> arch/arm/dts/sun8i-h3-nanopi-m1.dts | 11 +++++++++++
>>>>>>> 1 file changed, 11 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/dts/sun8i-h3-nanopi-m1.dts
>>>>>>> b/arch/arm/dts/sun8i-h3-nanopi-m1.dts
>>>>>>> index ec63d10..9c1c380 100644
>>>>>>> --- a/arch/arm/dts/sun8i-h3-nanopi-m1.dts
>>>>>>> +++ b/arch/arm/dts/sun8i-h3-nanopi-m1.dts
>>>>>>> @@ -55,6 +55,17 @@
>>>>>>> status = "okay";
>>>>>>> };
>>>>>>>
>>>>>>> +&emac {
>>>>>>> + phy = <&phy1>;
>>>>>>> + phy-mode = "mii";
>>>>>>> + allwinner,use-internal-phy;
>>>>>>> + allwinner,leds-active-low;
>>>>>>> + status = "okay";
>>>>>>> + phy1: ethernet-phy at 1 {
>>>>>>> + reg = <1>;
>>>>>>> + };
>>>>>>> +};
>>>>>>
>>>>>>
>>>>>> We usually sync Linux for dts changes and I've seen few patches on
>>>>>> Linux, lets wait Linux to merge.
>>>>>>
>>>>>> thanks!
>>>>>>
>>>>> Ok thanks, I didn't know this.
>>>>>
>>>>> Are there also some plans to snyc the sun8i-dwmac driver?
>>>>
>>>> No such plan as of now.
>>>
>>> There's apritzel's work on this in this branch:
>>>
>>> https://github.com/apritzel/u-boot/commits/a64-pending
>>
>> OK, thanks for the info
>>
>> thanks!
>
> How shoud we proceed with this patch series?
>
> My linux mainline patches were rejected since the dwmac-sun8i bindings have
> not stabilized yet:
> http://www.spinics.net/lists/kernel/msg2592861.html

You should wait until the bindings have stabilized, then resync the dts
files from Linux to U-boot, and fix up the driver to support the new
bindings.

ChenYu