[U-Boot] [PATCH 05/19] arm: socfpga: Enhance FPGA program support with at least 4 byte data

Chee, Tien Fong
2017-09-04T07:09:05Z

On Rab, 2017-08-30 at 10:55 +0200, Marek Vasut wrote:
> On 08/30/2017 10:24 AM, Chee, Tien Fong wrote:
> >
> > On Sel, 2017-08-29 at 13:58 +0200, Marek Vasut wrote:
> > >
> > > On 08/29/2017 12:45 PM, tien.fong.chee at intel.com wrote:
> > > >
> > > >
> > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > >
> > > > This patch enables FPGA program with minimum 4 byte data size.
> > > What does that mean ? Expand the description, it's inobvious
> > >
> > The exisitng FPGA program function only support the FPGA data which
> > size is >= 32 bytes. For the size smaller than that, the operation
> > would have failed.
> Because ... ?
>
> And you fix it how ... ?
>
> That should be in the commit message, describe the problem and how
> you
> fix it.
>
Okay.
> >
> > >
> > > >
> > > >
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > ---
> > > >  drivers/fpga/socfpga.c |   14 ++++++++------
> > > >  1 files changed, 8 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
> > > > index 28fa16b..6e14ebd 100644
> > > > --- a/drivers/fpga/socfpga.c
> > > > +++ b/drivers/fpga/socfpga.c
> > > > @@ -1,5 +1,5 @@
> > > >  /*
> > > > - * Copyright (C) 2012 Altera Corporation <www.altera.com>
> > > > + * Copyright (C) 2012-2017 Altera Corporation <www.altera.com>
> > > >   * All rights reserved.
> > > >   *
> > > >   * SPDX-License-Identifier: BSD-3-Clause
> > > > @@ -55,18 +55,20 @@ void fpgamgr_program_write(const void
> > > > *rbf_data, size_t rbf_size)
> > > >   uint32_t loops4 = DIV_ROUND_UP(rbf_size % 32, 4);
> > > >
> > > >   asm volatile(
> > > > + " cmp %2, #0\n"
> > > > + " beq 2f\n"
> > > >   "1: ldmia %0!, {r0-r7}\n"
> > > >   " stmia %1!, {r0-r7}\n"
> > > >   " sub %1, #32\n"
> > > >   " subs %2, #1\n"
> > > >   " bne 1b\n"
> > > > - " cmp %3, #0\n"
> > > > - " beq 3f\n"
> > > > - "2: ldr %2, [%0],
> > > > #4\n
> > > > "
> > > > + "2: cmp %3, #0\n"
> > > > + " beq 4f\n"
> > > > + "3: ldr %2, [%0],
> > > > #4\n
> > > > "
> > > >   " str %2, [%1]\n"
> > > >   " subs %3, #1\n"
> > > > - " bne 2b\n"
> > > > - "3: nop\n"
> > > > + " bne 3b\n"
> > > > + "4: nop\n"
> > > >   : "+r"(src), "+r"(dst), "+r"(loops32),
> > > > "+r"(loops4) :
> > > >   : "r0", "r1", "r2", "r3", "r4", "r5", "r6",
> > > > "r7",
> > > > "cc");
> > > >  }
> > > >
>