[U-Boot] [PATCH v2 02/19] doc: dtbinding: Description on FPGA RBF properties at Arria 10 FPGA manager

Chee, Tien Fong
2017-09-27T03:12:45Z

On Sel, 2017-09-26 at 12:30 +0200, Marek Vasut wrote:
> On 09/26/2017 10:54 AM, Chee, Tien Fong wrote:
> >
> > On Isn, 2017-09-25 at 11:00 +0200, Marek Vasut wrote:
> > >
> > > On 09/25/2017 10:39 AM, tien.fong.chee at intel.com wrote:
> > > >
> > > >
> > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > >
> > > > This patch adds description on properties about location of
> > > > FPGA
> > > > RBFs are
> > > > stored, type and functionality of RBF used to configure FPGA.
> > > >
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > Why does this patch have different tags than 1/19 ? Please keep
> > > things
> > > consistent ...
> > >
> > Not get you. What's you means for tags?
> ARM: socfpga: , not the random doc: dtbinding: .
> Heck, the first and second patch change the same file, yet have
> different tags, why ?
>
I ported patch 01 from Linux, so i keep everything intact. For patch
02, i put doc:dtbinding because i think that is more descriptive to the
file i changed.
I can change to ARM:socfpga .
> >
> > >
> > > >
> > > > ---
> > > >  doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt
> > > > | 11
> > > > +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-
> > > > fpga-
> > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-
> > > > fpga-
> > > > mgr.txt
> > > > index 2fd8e7a..7abb746 100644
> > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-
> > > > mgr.txt
> > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-
> > > > mgr.txt
> > > > @@ -7,6 +7,14 @@ Required properties:
> > > >                 - The second index is for writing FPGA
> > > > configuration data.
> > > >  - resets     : Phandle and reset specifier for the device's
> > > > reset.
> > > >  - clocks     : Clocks used by the device.
> > > > +- bitstream_periph : FPGA peripheral raw binary file which is
> > > > used
> > > > to
> > > > +                     initialize FPGA IOs, PLL, IO48 and DDR.
> > > > +- bitstream_core : FPGA core raw binary file contains FPGA
> > > > design
> > > > which is used
> > > > +                   to program FPGA CRAM and ERAM.
> > > > +- bitstream_devpart : Partition of flash device where
> > > > bitstream
> > > > files are
> > > > +        stored.
> > > > +                      <dev[:part]> - dev is flash device
> > > > number,
> > > > part is flash
> > > > +                                     device partition.
> > > >
> > > >  Example:
> > > >
> > > > @@ -16,4 +24,7 @@ Example:
> > > >          0xffcfe400 0x20>;
> > > >   clocks = <&l4_mp_clk>;
> > > >   resets = <&rst FPGAMGR_RESET>;
> > > > + bitstream_periph =
> > > > "ghrd_10as066n2.periph.rbf.mkimage";
> > > > + bitstream_core =
> > > > "ghrd_10as066n2.core.rbf.mkimage";
> > > > + bitstream_devpart = "0:1";
> > > >   };
> > > >
>