public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dwc: ep0: Allocate and flush dwc->ep0_trb in a cache aligned manner
Date: Tue, 03 Oct 2017 12:08:59 +0300	[thread overview]
Message-ID: <1507021739.16112.227.camel@linux.intel.com> (raw)
In-Reply-To: <60a68e65-e6c4-3371-90a5-3cc782e99e3e@ti.com>

On Tue, 2017-10-03 at 13:05 +0530, Faiz Abbas wrote:
> Hi,
> 
> On Tuesday 19 September 2017 04:45 PM, Faiz Abbas wrote:
> > A flush of the cache is required before any DMA access can take
> > place.
> > The minimum size that can be flushed from the cache is one cache
> > line
> > size. Therefore, any buffer allocated for DMA should be in multiples
> > of cache line size.
> > 
> > Thus, allocate memory for ep0_trb in multiples of cache line size.
> > 
> > Also, when local variable trb is assigned to dwc->ep0_trb[1] and
> > used
> > to flush cache, it leads to cache misaligned messages as only the
> > base
> > address dwc->ep0_trb is cache aligned.
> > 
> > Therefore, flush cache using ep0_trb_addr which is always cache
> > aligned.
> > 
> > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> 
> Gentle ping.

Can you resend with Felipe Balbi included?

And I'm not sure Vincent is anyhow related to this anymore (or even
works with us).

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-10-03  9:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 11:15 [U-Boot] [PATCH] dwc: ep0: Allocate and flush dwc->ep0_trb in a cache aligned manner Faiz Abbas
2017-10-03  7:35 ` Faiz Abbas
2017-10-03  9:08   ` Andy Shevchenko [this message]
2017-10-03  9:43     ` Marek Vasut
2017-10-03  9:58 ` Faiz Abbas
2017-10-03 12:04 ` Marek Vasut
2017-10-03 12:18   ` Dr. Philipp Tomsich
2017-10-03 12:52     ` Marek Vasut
2017-10-03 13:17   ` Faiz Abbas
2017-10-03 13:18     ` Marek Vasut
2017-10-04 10:51       ` Faiz Abbas
2017-10-04 12:31         ` Marek Vasut
2017-10-04 13:11           ` Faiz Abbas
2017-10-05 11:27             ` Marek Vasut
2017-10-06 11:33               ` Faiz Abbas
2017-10-10  5:37                 ` Faiz Abbas
2017-10-10  5:48                   ` Kishon Vijay Abraham I
2017-10-10  8:00                     ` Marek Vasut
2017-10-10 10:45                       ` Faiz Abbas
2017-10-10 13:49                         ` Marek Vasut
2017-10-11  8:23                           ` Faiz Abbas
2017-10-11  8:58                             ` Kishon Vijay Abraham I
2017-10-11 13:23                               ` Faiz Abbas
2017-10-03 13:01 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507021739.16112.227.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox