* [U-Boot] [PATCH 1/2] wandboard: Remove cpu type check prior to setup_sata()
@ 2017-10-15 13:21 Fabio Estevam
2017-10-15 13:21 ` [U-Boot] [PATCH 2/2] udoo: " Fabio Estevam
2017-10-18 16:53 ` [U-Boot] [PATCH 1/2] wandboard: " Heinrich Schuchardt
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-10-15 13:21 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
Inside setup_sata() there is a cpu type check, so there is no need to
do this check in the board file.
This also brings the benefit to allowing setup_sata() to be called for the
mx6qp wandboard variant.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
board/wandboard/wandboard.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index adfcf48..3f12b50 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -380,9 +380,7 @@ int board_early_init_f(void)
setup_display();
#endif
#ifdef CONFIG_SATA
- /* Only mx6q wandboard has SATA */
- if (is_cpu_type(MXC_CPU_MX6Q))
- setup_sata();
+ setup_sata();
#endif
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] udoo: Remove cpu type check prior to setup_sata()
2017-10-15 13:21 [U-Boot] [PATCH 1/2] wandboard: Remove cpu type check prior to setup_sata() Fabio Estevam
@ 2017-10-15 13:21 ` Fabio Estevam
2017-10-18 16:52 ` Heinrich Schuchardt
2017-10-18 16:53 ` [U-Boot] [PATCH 1/2] wandboard: " Heinrich Schuchardt
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-10-15 13:21 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
Inside setup_sata() there is a cpu type check, so there is no need to
do this check in the board file.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
board/udoo/udoo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/board/udoo/udoo.c b/board/udoo/udoo.c
index a359626..562f0d8 100644
--- a/board/udoo/udoo.c
+++ b/board/udoo/udoo.c
@@ -245,8 +245,7 @@ int board_init(void)
gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
#ifdef CONFIG_SATA
- if (is_cpu_type(MXC_CPU_MX6Q))
- setup_sata();
+ setup_sata();
#endif
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] udoo: Remove cpu type check prior to setup_sata()
2017-10-15 13:21 ` [U-Boot] [PATCH 2/2] udoo: " Fabio Estevam
@ 2017-10-18 16:52 ` Heinrich Schuchardt
0 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2017-10-18 16:52 UTC (permalink / raw)
To: u-boot
On 10/15/2017 03:21 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Inside setup_sata() there is a cpu type check, so there is no need to
> do this check in the board file.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/udoo/udoo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/udoo/udoo.c b/board/udoo/udoo.c
> index a359626..562f0d8 100644
> --- a/board/udoo/udoo.c
> +++ b/board/udoo/udoo.c
> @@ -245,8 +245,7 @@ int board_init(void)
> gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
>
> #ifdef CONFIG_SATA
> - if (is_cpu_type(MXC_CPU_MX6Q))
> - setup_sata();
> + setup_sata();
> #endif
> return 0;
> }
>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] wandboard: Remove cpu type check prior to setup_sata()
2017-10-15 13:21 [U-Boot] [PATCH 1/2] wandboard: Remove cpu type check prior to setup_sata() Fabio Estevam
2017-10-15 13:21 ` [U-Boot] [PATCH 2/2] udoo: " Fabio Estevam
@ 2017-10-18 16:53 ` Heinrich Schuchardt
1 sibling, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2017-10-18 16:53 UTC (permalink / raw)
To: u-boot
On 10/15/2017 03:21 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Inside setup_sata() there is a cpu type check, so there is no need to
> do this check in the board file.
>
> This also brings the benefit to allowing setup_sata() to be called for the
> mx6qp wandboard variant.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/wandboard/wandboard.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index adfcf48..3f12b50 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -380,9 +380,7 @@ int board_early_init_f(void)
> setup_display();
> #endif
> #ifdef CONFIG_SATA
> - /* Only mx6q wandboard has SATA */
> - if (is_cpu_type(MXC_CPU_MX6Q))
> - setup_sata();
> + setup_sata();
> #endif
>
> return 0;
>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-18 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 13:21 [U-Boot] [PATCH 1/2] wandboard: Remove cpu type check prior to setup_sata() Fabio Estevam
2017-10-15 13:21 ` [U-Boot] [PATCH 2/2] udoo: " Fabio Estevam
2017-10-18 16:52 ` Heinrich Schuchardt
2017-10-18 16:53 ` [U-Boot] [PATCH 1/2] wandboard: " Heinrich Schuchardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox