From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARC: HSDK: introduce CREG GPIO driver
Date: Mon, 16 Oct 2017 12:30:27 +0000 [thread overview]
Message-ID: <1508157026.4941.44.camel@synopsys.com> (raw)
In-Reply-To: <20171013132143.26340-1-Eugeniy.Paltsev@synopsys.com>
Hi Eugeniy,
On Fri, 2017-10-13 at 16:21 +0300, Eugeniy Paltsev wrote:
> The HSDK can manage some pins via CREG registers block.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> MAINTAINERS | 6 +++
> drivers/gpio/Kconfig | 7 +++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/hsdk-creg-gpio.c | 109 ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 123 insertions(+)
> create mode 100644 drivers/gpio/hsdk-creg-gpio.c
I've got this one applied on top of today's upstream master and with
enabled HSDK GPIO driver I'm seeing this build failure:
------------------------------>8-----------------------------
LD cmd/built-in.o
drivers/gpio/hsdk-creg-gpio.c: In function ‘hsdk_creg_gpio_direction_input’:
drivers/gpio/hsdk-creg-gpio.c:55:2: warning: implicit declaration of function ‘error’ [-Wimplicit-function-declaration]
error("hsdk-creg-gpio can't be used as input!\n");
^~~~~
LD drivers/gpio/built-in.o
LD common/built-in.o
make[2]: 'arch/arc/dts/hsdk.dtb' is up to date.
CC lib/display_options.o
LD lib/built-in.o
LD u-boot
drivers/gpio/built-in.o: In function `hsdk_creg_gpio_direction_input':
.../u-boot/drivers/gpio/hsdk-creg-gpio.c:55: undefined reference to `error'
.../u-boot/drivers/gpio/hsdk-creg-gpio.c:55: undefined reference to `error'
Makefile:1256: recipe for target 'u-boot' failed
------------------------------>8-----------------------------
Could you please check what's wrong there and fix it.
-Alexey
prev parent reply other threads:[~2017-10-16 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:21 [U-Boot] [PATCH] ARC: HSDK: introduce CREG GPIO driver Eugeniy Paltsev
2017-10-13 13:33 ` Alexey Brodkin
2017-10-13 13:46 ` Tom Rini
2017-10-13 13:55 ` Alexey Brodkin
2017-10-13 13:55 ` Tom Rini
2017-10-16 12:30 ` Alexey Brodkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508157026.4941.44.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox