* [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP
@ 2017-11-10 17:33 Andy Shevchenko
2017-11-20 7:07 ` Bin Meng
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2017-11-10 17:33 UTC (permalink / raw)
To: u-boot
FLIS IP since now gets its own ACPI ID.
Drop PRP0001 workaround in favour of official ACPI HID.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index e80ec0a9be..288b57cb80 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -264,7 +264,7 @@ Device (PCI0)
Device (FLIS)
{
- Name (_HID, "PRP0001")
+ Name (_HID, "INTC1002")
Name (_DDN, "Intel Merrifield Family-Level Interface Shim")
Name (RBUF, ResourceTemplate()
{
@@ -284,13 +284,6 @@ Device (FLIS)
Return (RBUF)
}
- Name (_DSD, Package () {
- ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
- Package () {
- Package () {"compatible", "intel,merrifield-pinctrl"},
- }
- })
-
Method (_STA, 0, NotSerialized)
{
Return (STA_VISIBLE)
--
2.14.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP
2017-11-10 17:33 [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP Andy Shevchenko
@ 2017-11-20 7:07 ` Bin Meng
2017-11-20 12:17 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2017-11-20 7:07 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Sat, Nov 11, 2017 at 1:33 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> FLIS IP since now gets its own ACPI ID.
> Drop PRP0001 workaround in favour of official ACPI HID.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
BTW: can you put some xrefs in the commit message like where the new
ACPI ID is introduced? I did not find the "INTC1002" in my kernel
tree.
> diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
> index e80ec0a9be..288b57cb80 100644
> --- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
> +++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
> @@ -264,7 +264,7 @@ Device (PCI0)
>
> Device (FLIS)
> {
> - Name (_HID, "PRP0001")
> + Name (_HID, "INTC1002")
> Name (_DDN, "Intel Merrifield Family-Level Interface Shim")
> Name (RBUF, ResourceTemplate()
> {
> @@ -284,13 +284,6 @@ Device (FLIS)
> Return (RBUF)
> }
>
> - Name (_DSD, Package () {
> - ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> - Package () {
> - Package () {"compatible", "intel,merrifield-pinctrl"},
> - }
> - })
> -
> Method (_STA, 0, NotSerialized)
> {
> Return (STA_VISIBLE)
> --
Regards,
Bin
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP
2017-11-20 7:07 ` Bin Meng
@ 2017-11-20 12:17 ` Andy Shevchenko
2017-11-20 14:50 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2017-11-20 12:17 UTC (permalink / raw)
To: u-boot
On Mon, 2017-11-20 at 15:07 +0800, Bin Meng wrote:
> Hi Andy,
>
> On Sat, Nov 11, 2017 at 1:33 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > FLIS IP since now gets its own ACPI ID.
> > Drop PRP0001 workaround in favour of official ACPI HID.
> >
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Thanks, though I think it would be better to add _CRS as well to be
fully complete with device resources.
So, taking into consideration your below comment let me send v2 after
the ID makes Linux kernel.
> BTW: can you put some xrefs in the commit message like where the new
> ACPI ID is introduced? I did not find the "INTC1002" in my kernel
> tree.
The patch is under review, I'm pretty sure it will be in after merge
window closed.
> > Device (FLIS)
> > {
> > - Name (_HID, "PRP0001")
> > + Name (_HID, "INTC1002")
> > Name (_DDN, "Intel Merrifield Family-Level Interface Shim")
> > Name (RBUF, ResourceTemplate()
> > {
> > @@ -284,13 +284,6 @@ Device (FLIS)
> > Return (RBUF)
> > }
> >
> > - Name (_DSD, Package () {
> > - ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > - Package () {
> > - Package () {"compatible", "intel,merrifield-pinctrl"},
> > - }
> > - })
> > -
> > Method (_STA, 0, NotSerialized)
> > {
> > Return (STA_VISIBLE)
> > --
>
> Regards,
> Bin
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP
2017-11-20 12:17 ` Andy Shevchenko
@ 2017-11-20 14:50 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-11-20 14:50 UTC (permalink / raw)
To: u-boot
On Mon, 2017-11-20 at 14:17 +0200, Andy Shevchenko wrote:
> On Mon, 2017-11-20 at 15:07 +0800, Bin Meng wrote:
> >
> I think it would be better to add _CRS as well to be
> fully complete with device resources.
Ah, I have done this already (I'm talking about Memory32Fixed()
resource).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-20 14:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-10 17:33 [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP Andy Shevchenko
2017-11-20 7:07 ` Bin Meng
2017-11-20 12:17 ` Andy Shevchenko
2017-11-20 14:50 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox