public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wilson Lee <wilson.lee@ni.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ni: Add NIZYNQ platform
Date: Wed, 22 Nov 2017 03:06:19 +0000	[thread overview]
Message-ID: <1511319979.2707.8.camel@ni.com> (raw)
In-Reply-To: <d1aabb42-c29d-7c5a-63f7-d79b8621b214@monstr.eu>

Hi Michal,

On Wed, 2017-11-08 at 07:27 +0100, Michal Simek wrote:
> On 8.11.2017 03:54, Wilson Lee wrote:
> > 
> > Initial platform creation for NIZYNQ.
> > 
> > Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> > Signed-off-by: Keng Soon Cheah <keng.soon.cheah@ni.com>
> > Signed-off-by: Wilson Lee <wilson.lee@ni.com>
> > Cc: Chen Yee Chew <chen.yee.chew@ni.com>
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > ---
> >  arch/arm/Kconfig  | 15 +++++++++++++++
> >  arch/arm/Makefile |  4 +++-
> >  board/ni/Kconfig  | 13 +++++++++++++
> >  3 files changed, 31 insertions(+), 1 deletion(-)
> >  create mode 100644 board/ni/Kconfig
> > 
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 83b7aa5..ae34821 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -767,6 +767,20 @@ config ARCH_ZYNQMP
> >  	select DM_USB if USB
> >  	imply FAT_WRITE
> >  
> > +config NIZYNQ
> > +	bool "National Instruments zynq Platform"
> > +	select CPU_V7
> > +	select SUPPORT_SPL
> > +	select OF_CONTROL
> > +	select SPL_OF_CONTROL if SPL
> > +	select DM
> > +	select DM_ETH
> > +	select DM_GPIO
> > +	select SPL_DM if SPL
> > +	select DM_MMC
> > +	select DM_SERIAL
> > +	select SPL_SEPARATE_BSS if SPL
> > +
> What's the reason for this? You should reuse current ZYNQ fragment
> and
> if this selects something what you don't want then we should
> changethat. Look at syzygy or topic boards which are using existing
> zynq
> infrastructure.
> 
> Thanks,
> Michal
> 
> 

The reason for adding NIZYNQ instead of reuse ARCH_ZYNQ. That is
because we need NIZYNQ at the same level with ARCH_ZYNQ in menuconfig.
We are thinking that it would be missleading, if our customer need to
select Xilinx Zynq Platform before they can select NI product. 

Hence, what we wish to get the menuconfig that look like below,

+------------------------ Target select ------------------------+
|  Use the arrow keys to navigate this window or press the      |  
|  hotkey of the item you wish to select followed by the <SPACE |  
|  BAR>. Press <?> for additional information about this        |  
| +----^(-)---------------------------------------------------+ |  
| |( ) Support pcm-052                                        | |  
| |( ) Support BK4r1                                          | |  
| |( ) Xilinx Zynq Platform                                   | |  
| |( ) Support Xilinx ZynqMP Platform                         | |  
| |(X) National Instruments zynq Platform                     | |  
| |( ) NVIDIA Tegra                                           | |  
| +----+(+)---------------------------------------------------+ |  
+---------------------------------------------------------------+  
|                    <Select>      < Help >                     |  
+---------------------------------------------------------------+

  reply	other threads:[~2017-11-22  3:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  2:54 [U-Boot] [PATCH] ni: Add NIZYNQ platform Wilson Lee
2017-11-08  6:27 ` Michal Simek
2017-11-22  3:06   ` Wilson Lee [this message]
2017-11-22  7:11     ` Michal Simek
2017-11-23  3:42       ` Wilson Lee
2017-11-23  7:35         ` Michal Simek
2017-11-22  3:14   ` Wilson Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511319979.2707.8.camel@ni.com \
    --to=wilson.lee@ni.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox