public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Intel Edison build warning
Date: Fri, 24 Nov 2017 17:56:39 +0200	[thread overview]
Message-ID: <1511538999.25007.444.camel@linux.intel.com> (raw)
In-Reply-To: <1511538142.25007.441.camel@linux.intel.com>

On Fri, 2017-11-24 at 17:42 +0200, Andy Shevchenko wrote:
> On Fri, 2017-11-24 at 16:06 +0800, Bin Meng wrote:
> > Hi,
> > 
> > Intel Edison has a build warning below.
> > 
> > +  *env_addr = offset;
> > +            ^
> > w+../env/mmc.c: In function 'mmc_get_env_addr':
> > w+../env/mmc.c:121:12: warning: 'val' may be used uninitialized in
> > this function [-Wmaybe-uninitialized]
> > 
> > I did not figure out what is wrong here. v2017.11 does not have such
> > build warning.
> > 
> > Do you have any idea?

Somewhat compiler goes crazy?

I have a theory that instead of showing actual potential issues (which
are bogus anyway) it complains on __weak function instead.

The real complains might be env_mmc_load() / env_mmc_save() where
offset* is uninitialized indeed.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-11-24 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24  8:06 [U-Boot] Intel Edison build warning Bin Meng
2017-11-24 15:42 ` Andy Shevchenko
2017-11-24 15:56   ` Andy Shevchenko [this message]
2017-11-27  2:34     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511538999.25007.444.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox