From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Tue, 28 May 2013 20:57:00 +0200 (CEST) Subject: [U-Boot] [PATCH v4 1/7] arm: vf610: Add IOMUX support for Vybrid VF610 In-Reply-To: <1369731347-9994-2-git-send-email-b18965@freescale.com> References: <1369731347-9994-1-git-send-email-b18965@freescale.com> <1369731347-9994-2-git-send-email-b18965@freescale.com> Message-ID: <1512799881.1269794.1369767420172.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alison, On Tuesday, May 28, 2013 10:55:41 AM, Alison Wang wrote: > This patch adds the IOMUX support for Vybrid VF610 platform. > > There is a little difference for IOMUXC module between VF610 and i.MX > platform, the muxmode and pad configuration share one 32bit register on > VF610, but they are two independent registers on I.MX platform. A > CONFIG_IOMUX_SHARE_CONFIG_REG was introduced to fit this difference. > > Signed-off-by: Alison Wang [...] > diff --git a/arch/arm/imx-common/iomux-v3.c b/arch/arm/imx-common/iomux-v3.c > index 7fe5ce7..35880c7 100644 > --- a/arch/arm/imx-common/iomux-v3.c > +++ b/arch/arm/imx-common/iomux-v3.c > @@ -48,8 +48,14 @@ void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad) > if (sel_input_ofs) > __raw_writel(sel_input, base + sel_input_ofs); > > +#ifdef CONFIG_IOMUX_SHARE_CONF_REG Where is this one defined? I don't see it in include/configs/vf610twr.h. Why not use "#ifdef CONFIG_VF610" since this is a platform-dependent code, and not a board-specific config option? > + if (!(pad_ctrl & NO_PAD_CTRL)) > + __raw_writel((mux_mode << PAD_MUX_MODE_SHIFT) | pad_ctrl, > + base + pad_ctrl_ofs); > +#else > if (!(pad_ctrl & NO_PAD_CTRL) && pad_ctrl_ofs) > __raw_writel(pad_ctrl, base + pad_ctrl_ofs); > +#endif > } > > void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list, [...] Apart from that, this patch is OK. Best regards, Beno?t