From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chee, Tien Fong <tien.fong.chee@intel.com>
Date: Tue, 12 Dec 2017 04:51:44 +0000
Subject: [U-Boot] [PATCH 2/2] common: Generic firmware loader for file
	system
In-Reply-To: <20171211131656.5466c9e5@karo-electronics.de>
References: <1512989626-4303-1-git-send-email-tien.fong.chee@intel.com>
 <1512989626-4303-3-git-send-email-tien.fong.chee@intel.com>
 <20171211131656.5466c9e5@karo-electronics.de>
Message-ID: <1513054302.2900.3.camel@intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Isn, 2017-12-11 at 13:16 +0100, Lothar Waßmann wrote:
> Hi,
> 
> On Mon, 11 Dec 2017 18:53:46 +0800 tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> [...}
> > 
> > +/*
> > + * Prepare firmware struct;
> > + * return -ve if fail.
> > + */
> > +static int _request_firmware_prepare(struct firmware **firmware_p,
> > +				     const char *name, void *dbuf,
> > +				     size_t size, u32 offset)
> > +{
> > +	struct firmware *firmware = NULL;
> > +	int ret = 0;
> > +
> > +	*firmware_p = NULL;
> > 
> Sigh. This is useless...
> > 
> > +	if (!name || name[0] == '\0')
> > +		ret = -EINVAL;
> > +
> unless you do a 'return -EINVAL' here!
> 
You are right, i missed to change this to return. I would fix it.
> > 
> > +	*firmware_p = firmware = calloc(1, sizeof(*firmware));
> > +
> > +	if (!firmware) {
> > +		printf("%s: calloc(struct firmware) failed\n",
> > __func__);
> > +		return -ENOMEM;
> > +	}
> > +
> > +	firmware->name = name;
> > +	firmware->data = dbuf;
> > +	firmware->size = size;
> > +	firmware->offset = offset;
> > +
> > +	return ret;
> > +}
> > +
> 
> Lothar Waßmann