public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board
Date: Wed, 20 Dec 2017 15:37:13 +0200	[thread overview]
Message-ID: <1513777033.5797.14.camel@tuxera.com> (raw)
In-Reply-To: <20171220122641.jpki6wzuesyjneji@flea.lan>

On Wed, 2017-12-20 at 13:26 +0100, Maxime Ripard wrote:
> On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote:
> > After the previous commit which adds support for the cd-inverted
> > property to the sunxi MMC driver, driver-model MMC works fine on
> > this
> > board.
> > 
> > Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
> > ---
> >  configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig
> > b/configs/Linksprite_pcDuino3_Nano_defconfig
> > index 13538fafd1..44ce8b3ead 100644
> > --- a/configs/Linksprite_pcDuino3_Nano_defconfig
> > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig
> > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y
> >  # CONFIG_SPL_ISO_PARTITION is not set
> >  # CONFIG_SPL_EFI_PARTITION is not set
> >  CONFIG_SCSI_AHCI=y
> > +CONFIG_DM_MMC=y
> >  CONFIG_ETH_DESIGNWARE=y
> >  CONFIG_RGMII=y
> >  CONFIG_SUN7I_GMAC=y
> >  CONFIG_SCSI=y
> > +CONFIG_DM_SCSI=y
> 
> Those should not be in a single defconfig, but enabled for all the
> Allwinner boards (that have SATA and MMC).
> 
> Maxime
> 

Makes sense. I don't have any other boards to test with so I just
imitated Simon's change for the non-Nano pcduino3.

I will try to see if this could be imply'd in Kconfig.

  reply	other threads:[~2017-12-20 13:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 20:09 [U-Boot] [PATCH 1/2] mmc: sunxi: Support cd-inverted DT property Tuomas Tynkkynen
2017-12-18 20:09 ` [U-Boot] [PATCH 2/2] ARM: sunxi: Enable DM MMC+SATA for the PcDuino3 Nano board Tuomas Tynkkynen
2017-12-20 12:26   ` Maxime Ripard
2017-12-20 13:37     ` Tuomas Tynkkynen [this message]
2017-12-21 12:59       ` Maxime Ripard
2017-12-20 12:26 ` [U-Boot] [PATCH 1/2] mmc: sunxi: Support cd-inverted DT property Maxime Ripard
2017-12-20 13:34   ` Tuomas Tynkkynen
2017-12-21 13:09     ` Maxime Ripard
2017-12-21 14:09       ` Tuomas Tynkkynen
2017-12-21 15:49         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513777033.5797.14.camel@tuxera.com \
    --to=tuomas@tuxera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox